From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42BAD33BBD9 for ; Tue, 12 May 2026 19:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778613734; cv=none; b=rqbb9G2ryqhNu4PoPX5RumebWmInI3NLmJt57hrTi1L67LEFOhLQK/0twA0Iywdwe5TquIXg8OmXeR3ZoUXejt9E2z55RcMdos2H38n7HzVqfQu2PTKI3UkMjaPYOiBfGvXaRlo/9GQymdPFNTHNyRjqFxlf1kg9JG/fQObHqYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778613734; c=relaxed/simple; bh=7fsfeDD5zsNoYVgje1C07OQIG+0JdbWQD1nkccVjhc0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IcKEkRviyoP1wZbR6v0io/Fa/TjW4akuDMQhfH0AUYUm1LysvyKRJWCK3ps6o/Wz51zgZyyqHsOs1xNGRKdWoBm6DXlQEVzHlm9adVViHBWHM6AGpO8r1fjxwiEjyzoDvXr4p1sSrlDACLIHSPom/xdDJGyKDDT0XGp0W+3vhng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=BObeh3Jc; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="BObeh3Jc" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8ea8563c693so637090185a.2 for ; Tue, 12 May 2026 12:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1778613731; x=1779218531; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ks/LjlQK/JG7n2hZUU+2VkG9aSuUcSPPQPk8i5p6XOY=; b=BObeh3Jc3nZpYmPyeeIy9Kr1gweFviS4e0Bfj1jMqiAOXLkXq+vKxPwx2FgFYnEFZc ajwk4bE3U+C4KU1pQHAZxAbqlDTjR54k49Kmqfdb1MO92cN4M8gsSTStFs8qs14wdZUG H4X80yjAoDZlO3B/RySF4kbP7c1TAoOa8ud27Au/MRdpRmijjXX/pm+BT9KrhJDo9K92 TD1HLg9rxSIZobmlcfbVay8gAsBY/eoxp6IbG5IBgRSUW2PDqFQKiA6Wf4Kny678Ng85 UUKFxiA2Ag0dfFuOFaW09uZ4Tqx1/CjhGRTnfbkGpTAldn/eIqYieqPsIxF3iclEGajV rdzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778613731; x=1779218531; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ks/LjlQK/JG7n2hZUU+2VkG9aSuUcSPPQPk8i5p6XOY=; b=snvomS3cu40wzjljUMucBotEqvT2Tn1Vzq3Fu2+iJmr0gAxMqfqz8HWGxnXgm68GOy Uzfw+P4IGRsYidyPDbt2oxhn7/dmvl+wOOpcF1rohoQh9UBqsG+Kl/DS+nyntym/nuvF MiwtpM1Ffk2Nf42uQJP0vOMS0hsC8qF15hvU7pfUWGJfLfTuBbDGFVYOOzCKm7m4R/gS xxZOdBJVH958QsrSQRnfWO2NKV7mNnt1Rlt2uBu1ZyBryjIPbtLcobqo0qbq4Qx0yU3n T+XPwBYSDBLG81OPdounB0wbFRx3R9aqRGwCszqXHMOjI/vCBL55093mwgIyrqpvrKBx 9EBQ== X-Gm-Message-State: AOJu0Ywxci2mESKzBMIBl+t09DR2q2JHix+hnJ/Y4ccAdGpo1AGyZaO5 m7Ms2WHxf6woU/HMlCzovKV1TG7ZmSYUMaWBo786TiAeJToe4Xr8IDVEbFyflThg1vY= X-Gm-Gg: Acq92OEebyw11ZijhP4lVVhnXd8QtyBbZR364MlMTFBkjAVI7eMg0+OFHXpKZCZz0Bg pbOeLh18+CoWz9J8qZpKMipDlp18LygVvBBkGjr4j8cKipUKID5rOEAEZZhpW91HquBla+kWiZH 1rtv835+oFIpX5SJ8BbJpPXEWsDg3y067kdP6TEdy5RIFlFlQkKOPD0ICmcdZ+rfJRnUHvUgFYd JrJhiH8Fx+Y2TUNkEkDqBrt9tFMTt1PceTvGv9QDI+Wm/PD295/7kTICcpiGx+hDiBUrSBDIlH7 6O7FiVhGu1aNgvTSTyz1CbByKnmeD7q+MhZGqeejAASp5atCmGliYfhkx++ZUErRjeUPi4Nl4iS 2feJn/1qsYZBUiykOtzU3FvcsJLUJa9Gfz/fkrRCEk+wC/v0skHFG7+TDgmwSK6ENa0b+HmyXBb 97FimsFo+GyTnPtSZfcE01G890ndlo10u1UOYX1rWHNIH+4ojJ34a0yYTYlNR2eQU1zdMFYBOal fVpmw== X-Received: by 2002:a05:620a:f06:b0:8db:7315:706c with SMTP id af79cd13be357-90f8bb9a781mr41372185a.59.1778613731080; Tue, 12 May 2026 12:22:11 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id af79cd13be357-90d1b651259sm267869585a.21.2026.05.12.12.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 12:22:10 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wMsgE-00000000wzD-06XY; Tue, 12 May 2026 16:22:10 -0300 Date: Tue, 12 May 2026 16:22:10 -0300 From: Jason Gunthorpe To: Jiri Pirko Cc: linux-rdma@vger.kernel.org, leon@kernel.org, mrgolin@amazon.com, gal.pressman@linux.dev, sleybo@amazon.com, parav@nvidia.com, mbloch@nvidia.com, yanjun.zhu@linux.dev, marco.crivellari@suse.com, roman.gushchin@linux.dev, phaddad@nvidia.com, lirongqing@baidu.com, ynachum@amazon.com, huangjunxian6@hisilicon.com, kalesh-anakkur.purayil@broadcom.com, ohartoov@nvidia.com, michaelgur@nvidia.com, shayd@nvidia.com, edwards@nvidia.com, sriharsha.basavapatna@broadcom.com, andrew.gospodarek@broadcom.com, selvin.xavier@broadcom.com Subject: Re: [PATCH rdma-next v4 06/16] RDMA/uverbs: Push out CQ buffer umem processing into a helper Message-ID: <20260512192210.GL7702@ziepe.ca> References: <20260507125231.2950751-1-jiri@resnulli.us> <20260507125231.2950751-7-jiri@resnulli.us> <20260512180342.GI7702@ziepe.ca> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 12, 2026 at 08:40:26PM +0200, Jiri Pirko wrote: > Tue, May 12, 2026 at 08:03:42PM CEST, jgg@ziepe.ca wrote: > >On Thu, May 07, 2026 at 02:52:21PM +0200, Jiri Pirko wrote: > > > >> +static int uverbs_create_cq_get_buffer_desc(struct uverbs_attr_bundle *attrs, > >> + struct ib_uverbs_buffer_desc *desc) > >> +{ > >> + struct ib_device *ib_dev = attrs->context->device; > >> + int ret; > >> + > >> + if (uverbs_attr_is_valid(attrs, > >> UVERBS_ATTR_CREATE_CQ_BUFFER_VA)) { > > > >I know this is just moving code, but I've always disliked this > >function. I learned a trick using a case statement for this recently: > > > > u32 present_attrs = 0; > > if (uverbs_attr_is_valid(attrs, UVERBS_ATTR_CREATE_CQ_BUFFER_VA)) > > present_attrs |= BIT(UVERBS_ATTR_CREATE_CQ_BUFFER_VA); > > if (uverbs_attr_is_valid(attrs, UVERBS_ATTR_CREATE_CQ_BUFFER_LENGTH)) > > present_attrs |= BIT(UVERBS_ATTR_CREATE_CQ_BUFFER_LENGTH); > > if (uverbs_attr_is_valid(attrs, UVERBS_ATTR_CREATE_CQ_BUFFER_FD)) > > present_attrs |= BIT(UVERBS_ATTR_CREATE_CQ_BUFFER_FD); > > if (uverbs_attr_is_valid(attrs, UVERBS_ATTR_CREATE_CQ_BUFFER_OFFSET)) > > present_attrs |= BIT(UVERBS_ATTR_CREATE_CQ_BUFFER_OFFSET); > > > > switch (present_attrs) { > > case 0: > > return -ENODATA; > > case BIT(UVERBS_ATTR_CREATE_CQ_BUFFER_VA) | > > BIT(UVERBS_ATTR_CREATE_CQ_BUFFER_LENGTH): > >[..] > > return 0; > > case BIT(UVERBS_ATTR_CREATE_CQ_BUFFER_FD) | > > BIT(UVERBS_ATTR_CREATE_CQ_BUFFER_OFFSET) | > > BIT(UVERBS_ATTR_CREATE_CQ_BUFFER_LENGTH): > >[..] > > return 0; > > default: > > return -EINVAL; > > } > > > >No need to build the complex tests to check in each branch if the > >other branch attributes are presented. > > As this patch is just moving existing code, could we do this in a > follow-up? Patchset is already long enough. Will add that to my todo > list if you are okay with it. sure, I was just annoyed trying to understand this code again Jason