Re: [PATCH] IB/cm: unregister client groups when port registration fails in cm_add_one

[Leon Romanovsky <leon@kernel.org>]

On Mon, May 11, 2026 at 06:32:04PM +0800, Chenguang Zhao wrote:
> If ib_port_register_client_groups() fails, jumping to error1 skips
> ib_port_unregister_client_groups() for the current port because the
> cleanup loop only runs for strictly smaller port indices after --i.
> So jump to error2 to unregister the currently failed port.

Why? There is no need to call ib_port_unregister_client_groups() for the
current port. A failure in ib_port_register_client_groups() does not create
any sysfs groups that would require cleanup.

Thanks

> 
> Signed-off-by: Chenguang Zhao <zhaochenguang@kylinos.cn>
> ---
>  drivers/infiniband/core/cm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index 6ab9a0aee1ec..bcd347c78376 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -4378,7 +4378,7 @@ static int cm_add_one(struct ib_device *ib_device)
>  		ret = ib_port_register_client_groups(ib_device, i,
>  						     cm_counter_groups);
>  		if (ret)
> -			goto error1;
> +			goto error2;
>  
>  		port->mad_agent = ib_register_mad_agent(ib_device, i,
>  							IB_QPT_GSI,
> -- 
> 2.25.1
> 
>