Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: "Dennis Dalessandro" <dennis.dalessandro@cornelisnetworks.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] PCI: Export pci_parent_bus_reset() for drivers to use
Date: Thu, 14 May 2026 18:39:27 +0300	[thread overview]
Message-ID: <20260514153927.GQ15586@unreal> (raw)
In-Reply-To: <alpine.DEB.2.21.2605121104560.46195@angie.orcam.me.uk>

On Tue, May 12, 2026 at 11:17:29AM +0100, Maciej W. Rozycki wrote:
> On Tue, 12 May 2026, Leon Romanovsky wrote:
> 
> > > Export pci_parent_bus_reset() so that drivers do not duplicate it.  
> > > Document the interface.
> [...]
> > 
> > I wouldn't recommend doing this solely for hfi1. The driver is likely to be
> > removed or significantly changed soon.
> > 
> > https://lore.kernel.org/linux-rdma/177516078937.637585.1447184858924347033.stgit@awdrv-04.cornelisnetworks.com/
> 
>  Thank you for the pointer.  FWIW as per the cover letter I have no own 
> interest in the driver and offered this cleanup as a general code quality 
> improvement.
> 
>  Dennis, please clarify your position, and if you'd rather this change 
> wasn't made, then I'll drop the patches from my local verification setup 
> and won't offer them again.

Let me put on my RDMA maintainer hat.

Since hfi1 is the only user of this newly exported symbol,
and it resides within RDMA, please drop this patch.

Thanks

> 
>   Maciej

  reply	other threads:[~2026-05-14 15:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05  0:03 [PATCH v2 0/2] PCI+IB/hfi1: Fold duplicate secondary bus reset code Maciej W. Rozycki
2026-05-05  0:03 ` [PATCH v2 1/2] PCI: Export pci_parent_bus_reset() for drivers to use Maciej W. Rozycki
2026-05-12  9:00   ` Leon Romanovsky
2026-05-12 10:17     ` Maciej W. Rozycki
2026-05-14 15:39       ` Leon Romanovsky [this message]
2026-05-14 16:29         ` Dennis Dalessandro
2026-05-05  0:03 ` [PATCH v2 2/2] IB/hfi1: Remove pci_parent_bus_reset() duplication Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514153927.GQ15586@unreal \
    --to=leon@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox