From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 591A6224FA; Sat, 23 May 2026 00:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779494577; cv=none; b=DiU/5xUZ1uLaGRpvkiXazst/WEl1aECcARYMyPJIKJEo5bknPSY1jDZOeMAkVh0LiVxKvzvzpn+SAWCfBak8bIkDES1YGXg4nzfmoA/IcO1wkMM8kJNA/qNxOOLnFFEwM2K07R6lJws/P0YC3ca8yNrDfwC/rNBABAc02KgaAeg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779494577; c=relaxed/simple; bh=XWTefVIn7GASisAnJeS9nBFWwYBW/22XnkQB1XyYkVI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aYb2NuRb8ttgRZmgPQq2PQi7o0izW1wmDniUJPSdHc2o2IQ7v2mhoLQjQRYy1qKdTS/SaEWTF/z3DAc+kFQuKCgtudi/w2QzusoLNAdrP2jtgtp/ubtT3SBaMHxnUpz7AhM7fYAnpXftbUQ9upeWcfafSddmMwnQ0TEz1QXzFyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hb0qTpyo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hb0qTpyo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1CE11F000E9; Sat, 23 May 2026 00:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779494576; bh=3qFxGfNI+DFzjVRcQB858Php3hAsReJ35Zc57upwwU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hb0qTpyoeh9XnrrxYBzXAuIvizMabT6SbKrheKCstLBgHUyTFUJJiu1BrrkP5OEgq 3wGGQOZAXj+cU4R53kH3MjWerjNUeKEn3QQfU6fmY3QLQLXKrT6+YZKkBS+MMS4ZN5 Rh08DNcNjLDmw+O0eO09cYOPllZFcMWogwddeToYNih98bOSwKR8ta29+3AGtZ4Mp2 Sls7/o9KbgGQZVxvF9WetzmceP3LEc0CZi2TylXluEEMLjFeNN4pZQ7515SGBerAh+ 9QsfzHQKp6uOp/Ukl40jlXOmi7eVSwXYfjTwWc6t4gG1xnbBTw7pxYKfcy2AUA5igz HE26HcAwRSBAQ== From: Chuck Lever To: Anna Schumaker Cc: , , Chuck Lever Subject: [PATCH v2 1/3] xprtrdma: Use sendctx DMA state for Send signaling Date: Fri, 22 May 2026 20:02:50 -0400 Message-ID: <20260523000252.465074-2-cel@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260523000252.465074-1-cel@kernel.org> References: <20260523000252.465074-1-cel@kernel.org> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever Send signaling matters only when the prepared Send has page mappings to unmap. Today that test is expressed indirectly with rl_kref, because the Send-side reference is taken only for Sends with mapped SGEs. Split the SGE DMA unmap loop into its own helper and use sc_unmap_count directly for the signaling decision. This keeps the current behavior but removes one dependency on the old rl_kref semantics before the request lifetime rules are changed. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/frwr_ops.c | 2 +- net/sunrpc/xprtrdma/rpc_rdma.c | 22 +++++++++++++--------- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_ops.c index 7f79a0a2601e..e5c71cf705a3 100644 --- a/net/sunrpc/xprtrdma/frwr_ops.c +++ b/net/sunrpc/xprtrdma/frwr_ops.c @@ -474,7 +474,7 @@ int frwr_send(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req) ++num_wrs; } - if ((kref_read(&req->rl_kref) > 1) || num_wrs > ep->re_send_count) { + if (req->rl_sendctx->sc_unmap_count || num_wrs > ep->re_send_count) { send_wr->send_flags |= IB_SEND_SIGNALED; ep->re_send_count = min_t(unsigned int, ep->re_send_batch, num_wrs - ep->re_send_count); diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c index 0e0f21974710..16b9987858d6 100644 --- a/net/sunrpc/xprtrdma/rpc_rdma.c +++ b/net/sunrpc/xprtrdma/rpc_rdma.c @@ -477,19 +477,11 @@ static void rpcrdma_sendctx_done(struct kref *kref) rep->rr_rxprt->rx_stats.reply_waits_for_send++; } -/** - * rpcrdma_sendctx_unmap - DMA-unmap Send buffer - * @sc: sendctx containing SGEs to unmap - * - */ -void rpcrdma_sendctx_unmap(struct rpcrdma_sendctx *sc) +static void rpcrdma_sendctx_dma_unmap(struct rpcrdma_sendctx *sc) { struct rpcrdma_regbuf *rb = sc->sc_req->rl_sendbuf; struct ib_sge *sge; - if (!sc->sc_unmap_count) - return; - /* The first two SGEs contain the transport header and * the inline buffer. These are always left mapped so * they can be cheaply re-used. @@ -498,7 +490,19 @@ void rpcrdma_sendctx_unmap(struct rpcrdma_sendctx *sc) ++sge, --sc->sc_unmap_count) ib_dma_unmap_page(rdmab_device(rb), sge->addr, sge->length, DMA_TO_DEVICE); +} +/** + * rpcrdma_sendctx_unmap - DMA-unmap Send buffer + * @sc: sendctx containing SGEs to unmap + * + */ +void rpcrdma_sendctx_unmap(struct rpcrdma_sendctx *sc) +{ + if (!sc->sc_unmap_count) + return; + + rpcrdma_sendctx_dma_unmap(sc); kref_put(&sc->sc_req->rl_kref, rpcrdma_sendctx_done); } -- 2.54.0