Re: [PATCH for-next v2 3/3] RDMA/erdma: Implement erdma_reg_user_mr_dmabuf

[Jason Gunthorpe <jgg@nvidia.com>]

On Mon, May 18, 2026 at 08:06:28PM +0800, Boshi Yu wrote:
> +	if (attr->flags & ERDMA_MEM_FLAG_DMABUF) {
> +		umem_dmabuf = ib_umem_dmabuf_get_pinned(&dev->ibdev,
> +							attr->start, attr->len,
> +							attr->fd, attr->access);
> +		if (IS_ERR(umem_dmabuf)) {

I don't want to see new MR implementations that use the get_pinned
interface.

Please implement the revoked interface Jacob added:

commit ff85a2ebacbdaec9f28c4660c991295ace93cd1c
Author: Jacob Moroni <jmoroni@google.com>
Date:   Thu Mar 5 17:08:24 2026 +0000

    RDMA/umem: Add pinned revocable dmabuf import interface
    
    Added an interface for importing a pinned but revocable dmabuf.
    This interface can be used by drivers that are capable of revocation
    so that they can import dmabufs from exporters that may require it,
    such as VFIO.


Any IBTA compliant device should be implement revoke at least through
regreg_mr.

Jason