From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jiri Pirko <jiri@resnulli.us>
Cc: linux-rdma@vger.kernel.org, leon@kernel.org, mrgolin@amazon.com,
gal.pressman@linux.dev, sleybo@amazon.com, parav@nvidia.com,
mbloch@nvidia.com, yanjun.zhu@linux.dev,
marco.crivellari@suse.com, roman.gushchin@linux.dev,
phaddad@nvidia.com, lirongqing@baidu.com, ynachum@amazon.com,
huangjunxian6@hisilicon.com, kalesh-anakkur.purayil@broadcom.com,
ohartoov@nvidia.com, michaelgur@nvidia.com, shayd@nvidia.com,
edwards@nvidia.com, sriharsha.basavapatna@broadcom.com,
andrew.gospodarek@broadcom.com, selvin.xavier@broadcom.com,
jmoroni@google.com
Subject: Re: [PATCH rdma-next v7 14/15] RDMA/mlx5: Use UMEM attribute for CQ doorbell record
Date: Wed, 27 May 2026 14:41:52 -0300 [thread overview]
Message-ID: <20260527174152.GC3528738@ziepe.ca> (raw)
In-Reply-To: <20260526144152.1422310-15-jiri@resnulli.us>
On Tue, May 26, 2026 at 04:41:51PM +0200, Jiri Pirko wrote:
> + /*
> + * The 8-byte DBR is programmed to the device as one DMA address,
> + * so it must live in a single contiguous DMA segment.
> + */
> + if (!ib_umem_is_contiguous(umem)) {
> + ib_umem_release(umem);
> kfree(page);
> + err = -EINVAL;
> goto out;
> }
Michael forgot to add an inline for this:
../drivers/infiniband/hw/mlx5/doorbell.c: In function \u2018mlx5_ib_db_map_user_desc\u2019:
../drivers/infiniband/hw/mlx5/doorbell.c:102:14: error: implicit declaration of function \u2018ib_umem_is_contiguous\u2019 [-Werror=implicit-function-declaration]
102 | if (!ib_umem_is_contiguous(umem)) {
Jason
next prev parent reply other threads:[~2026-05-27 17:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 14:41 [PATCH rdma-next v7 00/15] RDMA: Introduce generic buffer descriptor infrastructure for umem Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 01/15] RDMA/umem: Rename ib_umem_get() to ib_umem_get_va() Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 02/15] RDMA/umem: Split ib_umem_get_va() into a thin wrapper around __ib_umem_get_va() Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 03/15] RDMA/core: Introduce generic buffer descriptor infrastructure for umem Jiri Pirko
2026-05-27 15:50 ` Jason Gunthorpe
2026-05-27 17:07 ` Jiri Pirko
2026-05-27 17:40 ` Jason Gunthorpe
2026-05-26 14:41 ` [PATCH rdma-next v7 04/15] RDMA/umem: Route ib_umem_get_va() through ib_umem_get_attr_or_va() Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 05/15] RDMA/uverbs: Push out CQ buffer umem processing into a helper Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 06/15] RDMA/uverbs: Add CQ buffer UMEM attribute and driver helpers Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 07/15] RDMA/efa: Use ib_umem_get_cq_buf() for user CQ buffer Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 08/15] RDMA/mlx5: Use ib_umem_get_cq_buf_or_va() " Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 09/15] RDMA/bnxt_re: " Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 10/15] RDMA/mlx4: Use ib_umem_get_cq_buf() " Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 11/15] RDMA/uverbs: Remove legacy umem field from struct ib_cq Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 12/15] RDMA/uverbs: Use UMEM attributes for QP creation Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 13/15] RDMA/mlx5: Use UMEM attributes for QP buffers in create_qp Jiri Pirko
2026-05-26 14:41 ` [PATCH rdma-next v7 14/15] RDMA/mlx5: Use UMEM attribute for CQ doorbell record Jiri Pirko
2026-05-27 17:41 ` Jason Gunthorpe [this message]
2026-05-26 14:41 ` [PATCH rdma-next v7 15/15] RDMA/mlx5: Use UMEM attribute for QP " Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527174152.GC3528738@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=andrew.gospodarek@broadcom.com \
--cc=edwards@nvidia.com \
--cc=gal.pressman@linux.dev \
--cc=huangjunxian6@hisilicon.com \
--cc=jiri@resnulli.us \
--cc=jmoroni@google.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=marco.crivellari@suse.com \
--cc=mbloch@nvidia.com \
--cc=michaelgur@nvidia.com \
--cc=mrgolin@amazon.com \
--cc=ohartoov@nvidia.com \
--cc=parav@nvidia.com \
--cc=phaddad@nvidia.com \
--cc=roman.gushchin@linux.dev \
--cc=selvin.xavier@broadcom.com \
--cc=shayd@nvidia.com \
--cc=sleybo@amazon.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=yanjun.zhu@linux.dev \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox