From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87C9439184A for ; Tue, 2 Jun 2026 11:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780399271; cv=none; b=IMa5KGZNcADvGVs+puC5umHcybJJs7Wbt6m/5BmJQLYFRm3j5A/dqg9cgsLxq6VHm9VmjdFMtu2AJgyUYHmj51mVi/LX8whd668dvfBbG8kEYqPk0BFNn6JKMFA+9lwltGq6WAfCG1/Fa1OM4cDVakH/Q4kpLCDwYgHkqCU5fgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780399271; c=relaxed/simple; bh=mdyShz2Hb1nhbf16JMmhzAI3lw9uTjlKGNRSkU4NhIY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RZfQ2UUV2IRh2VvIEjVdQ3/904Z47y0INRv7948fXK4r1r560OrL5VTI3L9aoR95H74NgBC4bqQ8OqF0Uz5x12CbUs/g/8krp3dhBLgnOrF7/LFvVykCXKewvoWUenp5jT5Xy+65LS3xs5s6Gb6Al4j6diAOr6gwdUUExzbgNPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QWDREzUc; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QWDREzUc" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4903d730b1fso101484145e9.2 for ; Tue, 02 Jun 2026 04:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780399269; x=1781004069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=N+Mx9qxe5Noh2BseN2qEXUEhNI+HpIudHixhjkzy9lQ=; b=QWDREzUcNvwFfuiuy45CUK0AXWlgdkktBJ+GtFJ8FBXCqyxwgJFlKRhsPar2d2ZSS/ wF+OEbhaLwx7LV28ZPNWspdgAJm9xUvN96CZwuoAtPTffSCzW/4Fpr6/Mbt9enzRoXPK A8vQoiFTbt5B2mNhEoq1uAz7t7WnR63xJyAs9Jqz6Qq8pOBKts+L5/hKYYv7x9LFkOQk hLy4CUB02VWElNjR5IpQWxMuofdoGXhNgBfSxRh30zfh3WNMYPoKoGEmTte5sN9ugr58 IEZwZrfmGvoplpLC/y3c2bT2VXy/rXJ4VUqMPgGRnElRSiMysIq4uug9vXoy1EJesNkh bggA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780399269; x=1781004069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N+Mx9qxe5Noh2BseN2qEXUEhNI+HpIudHixhjkzy9lQ=; b=QpYhZRVaRuYp1jqAT2HE1bP2cjFQZ8gSGb4FN6xIso3rG/NRCRI9zHYFBj1rvAdAP6 j9+0dRbEnMhNHlWwSlKTfNoF1h0jpzYsxm85lBirGxYLtvPddhqmXRTdlKLbhUaQiniM YOiJezAqoYDtcxEql1zLAW7/AYiy/qgS3wDBlL+iY25mgCJ+Iooq8hd/NIA4C5OEXV5B MWqlj49Isyv9XzLkpmzrTQwbl4QruyzkY2Ed48vyqduxZtq7c6QNKwAuepkoClD2DQxH 64Q52YQ9USP1kfARgh0vROAh4WdukcGVT6CaGmZXG82/N+xQobEVYXaGgsm1FnYtUFwg FgbQ== X-Forwarded-Encrypted: i=1; AFNElJ/6ZlN1AbeX8lPd4eXqH0gaFROBPy/D/uO4HxWFUnevrdk1wQFYgmr9qrDAEfpHd7JjbtvLkG0jcRSY@vger.kernel.org X-Gm-Message-State: AOJu0YyhMLKlwzZQl4LS/5Ow0QyCz/wfSaMratSGurmz0cYWmnK+yh5W U3nKf5IS3InB3qCWJB7STvKkKeIUckN3RHxeBsjpexykOkH28WaawRxx X-Gm-Gg: Acq92OGUcJvsXJnTrdWS7ip1uUm4TljcCRdl3vnBOVd75akILImEXyEClDPCP87lbbt iknv7cH9qSjTdLYnDJZGl+HsB8s+fgHV4CPZZqKTEU/PtBJAy2ikqsuGaaNPca6lh/z7l4j8pFT LAmxuY6IAZGet/6VSbPOXU0sqMSqBi21rtW/xCKQwz1owXy7F9dSc77XyZ+642pjstnt6d0NPJe qKu+FG4Qx1eaSaGqd8P1WZqZGIAPt2qCKMSCIHvAeLGjd7s9arB2iZTssCZ1kMr4y/w/G4wJ9Ck Fxr8HuhiNEHzwPHMnMeA/31Qrnx1kZy2MPZbRDI0tXcwSagG+nxff3E1Z2hQCYUIZ5HoSQtzdMU MoqerRdbIF3q+UrKPbix6xYml2k6DpuCyTjrlOh25r5kYkbUgUO1C0mqj2Jn2KHAYkYvQAGkI8B FR7WMz4RpOeQBeDcv3QKAgupO+92tadUcRXHJmmBxxFaB6Pm6N8PnzI/f+EaEGCka1wPZJcng= X-Received: by 2002:a05:600c:46d1:b0:490:a7ab:bbe3 with SMTP id 5b1f17b1804b1-490a7abbd7fmr206981415e9.0.1780399268568; Tue, 02 Jun 2026 04:21:08 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef3559645sm31033836f8f.26.2026.06.02.04.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 04:21:08 -0700 (PDT) Date: Tue, 2 Jun 2026 12:21:04 +0100 From: David Laight To: Andy Shevchenko Cc: Bart Van Assche , Erni Sri Satya Vennela , mkalderon@marvell.com, Jason Gunthorpe , Leon Romanovsky , zyjzyj2000@gmail.com, sagi@grimberg.me, mgurtovoy@nvidia.com, haris.iqbal@ionos.com, jinpu.wang@ionos.com, kbusch@kernel.org, Jens Axboe , Christoph Hellwig , kch@nvidia.com, smfrench@gmail.com, linkinjeon@kernel.org, metze@samba.org, tom@talpey.com, chuck.lever@oracle.com, jlayton@kernel.org, neil@brown.name, okorniev@redhat.com, Dai.Ngo@oracle.com, trondmy@kernel.org, anna@kernel.org, achender@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, kees@kernel.org, ebadger@purestorage.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, Jason Gunthorpe Subject: Re: [PATCH rdma-next v6] RDMA: Change capability fields in ib_device_attr from int to u32 Message-ID: <20260602122104.20afa8b4@pumpkin> In-Reply-To: References: <20260601092534.1764560-1-ernis@linux.microsoft.com> <5d3cac2b-4011-49c5-a142-55c85d38e90f@acm.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 2 Jun 2026 12:21:58 +0300 Andy Shevchenko wrote: > On Mon, Jun 01, 2026 at 08:51:40AM -0700, Bart Van Assche wrote: > > On 6/1/26 2:25 AM, Erni Sri Satya Vennela wrote: > > ... > > > > - sdev->srq_size = min(srpt_srq_size, sdev->device->attrs.max_srq_wr); > > > + sdev->srq_size = min_t(u32, srpt_srq_size, sdev->device->attrs.max_srq_wr); > > > > min_t() shouldn't be used if there is an alternative available. For the > > SRP drivers, please make sure that both arguments of min() are unsigned > > instead of using min_t(). > > Ah, I just answered in similar way against v5. I also mentioned clamp() there. > IMHO it is also best to do min(value, 255) not min(255, value). Like an 'if' put the value you are comparing against second. The min_t(u8, x, y) you've removed are usually broken. Maybe I should change clamp() to allow clamp(int_var, 0, unsigned_var). That will need the order of the compares swapping (to do the low bound first). I think they used to be that way around, got changed by a commit that said it didn't change it! Correct code shouldn't care. -- David