Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yonatan Nachum <ynachum@amazon.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org, mrgolin@amazon.com,
	sleybo@amazon.com, matua@amazon.com, gal.pressman@linux.dev
Subject: Re: [PATCH for-rc] RDMA/efa: Validate SQ ring size against max LLQ sizey
Date: Tue, 2 Jun 2026 15:01:49 -0300	[thread overview]
Message-ID: <20260602180149.GT3195266@nvidia.com> (raw)
In-Reply-To: <20260602065103.GA18111@dev-dsk-ynachum-1b-aa121316.eu-west-1.amazon.com>

On Tue, Jun 02, 2026 at 06:51:03AM +0000, Yonatan Nachum wrote:
> On Mon, Jun 01, 2026 at 09:30:05PM -0300, Jason Gunthorpe wrote:
> > On Tue, May 26, 2026 at 08:15:36AM +0000, Yonatan Nachum wrote:
> > > Validate the SQ ring size against the device's max LLQ size. This
> > > ensures that when using 128-byte WQEs, userspace cannot exceed the queue
> > > limits.
> > > 
> > > On create QP, userspace provides the SQ ring size (depth x WQE size)
> > > which is validated against the max LLQ size.
> > > 
> > > Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")
> > > Reviewed-by: Michael Margolin <mrgolin@amazon.com>
> > > Signed-off-by: Yonatan Nachum <ynachum@amazon.com>
> > > ---
> > >  drivers/infiniband/hw/efa/efa_verbs.c | 27 ++++++++++++++++++---------
> > >  1 file changed, 18 insertions(+), 9 deletions(-)
> > 
> > The Sashiko comments look like they are worth addressing
> > 
> > https://sashiko.dev/#/patchset/20260517175216.614494-1-ynachum%40amazon.com
> > 
> > Jason
> 
> Hi, thanks for the answer.
> That is not the Sashiko link for the patch, its this:
> https://sashiko.dev/#/patchset/20260526081536.1203553-1-ynachum%40amazon.com

Oh boy, it is annoying to get the right one up :\

> I reviewed the comments and none of them is relevant for the patch.

Ok, applied to for-rc

Thanks,
Jason

      reply	other threads:[~2026-06-02 18:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  8:15 [PATCH for-rc] RDMA/efa: Validate SQ ring size against max LLQ size Yonatan Nachum
2026-06-01  9:16 ` Yonatan Nachum
2026-06-02  0:30 ` Jason Gunthorpe
2026-06-02  6:51   ` [PATCH for-rc] RDMA/efa: Validate SQ ring size against max LLQ sizey Yonatan Nachum
2026-06-02 18:01     ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260602180149.GT3195266@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=gal.pressman@linux.dev \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matua@amazon.com \
    --cc=mrgolin@amazon.com \
    --cc=sleybo@amazon.com \
    --cc=ynachum@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox