Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Bommarito <michael.bommarito@gmail.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Leon Romanovsky <leon@kernel.org>,
	linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/isert: reject login PDUs shorter than ISER_HEADERS_LEN
Date: Fri, 5 Jun 2026 13:18:28 -0300	[thread overview]
Message-ID: <20260605161828.GA2734548@nvidia.com> (raw)
In-Reply-To: <20260602194642.2273217-1-michael.bommarito@gmail.com>

On Tue, Jun 02, 2026 at 03:46:42PM -0400, Michael Bommarito wrote:
> @@ -1383,6 +1383,12 @@ isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc)
>  	ib_dma_sync_single_for_cpu(ib_dev, isert_conn->login_desc->dma_addr,
>  			ISER_RX_SIZE, DMA_FROM_DEVICE);
>  
> +	if (unlikely(wc->byte_len < ISER_HEADERS_LEN)) {
> +		isert_err("login request length %u is too short\n",
> +			  wc->byte_len);
> +		return;

I changed this to isert_dbg() since we don't want pre-auth log DOS
either.. Applied to for-rc

Thanks,
Jason

      reply	other threads:[~2026-06-05 16:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 19:46 [PATCH] IB/isert: reject login PDUs shorter than ISER_HEADERS_LEN Michael Bommarito
2026-06-05 16:18 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260605161828.GA2734548@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=michael.bommarito@gmail.com \
    --cc=sagi@grimberg.me \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox