From: Jason Gunthorpe <jgg@nvidia.com>
To: Jacob Moroni <jmoroni@google.com>
Cc: tatyana.e.nikolova@intel.com, leon@kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next 1/2] RDMA/irdma: Remove redundant legacy_mode checks
Date: Fri, 5 Jun 2026 14:11:37 -0300 [thread overview]
Message-ID: <20260605171137.GA2771195@nvidia.com> (raw)
In-Reply-To: <20260602214423.1315105-1-jmoroni@google.com>
On Tue, Jun 02, 2026 at 09:44:22PM +0000, Jacob Moroni wrote:
> The driver has the following invariants:
>
> 1. legacy_mode is only allowed on GEN_1 hardware (enforced
> in irdma_alloc_ucontext).
>
> 2. GEN_1 hardware does not set IRDMA_FEATURE_CQ_RESIZE or
> IRDMA_FEATURE_RTS_AE. These feature flags are only set
> for GEN_2 and GEN_3 hardware.
>
> Therefore, legacy_mode is always false if IRDMA_FEATURE_CQ_RESIZE
> or IRDMA_FEATURE_RTS_AE is set, so remove the redundant checks.
>
> Signed-off-by: Jacob Moroni <jmoroni@google.com>
> ---
> drivers/infiniband/hw/irdma/uk.c | 9 +++------
> drivers/infiniband/hw/irdma/user.h | 1 -
> drivers/infiniband/hw/irdma/verbs.c | 7 +------
> 3 files changed, 4 insertions(+), 13 deletions(-)
Applied to for-next
There are more sashiko existing issues:
https://sashiko.dev/#/patchset/20260602214423.1315105-1-jmoroni%40google.com
Some of them look like they need to be fixed
Jason
prev parent reply other threads:[~2026-06-05 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 21:44 [PATCH rdma-next 1/2] RDMA/irdma: Remove redundant legacy_mode checks Jacob Moroni
2026-06-02 21:44 ` [PATCH rdma-next 2/2] RDMA/irdma: Fix OOB read during CQ MR registration Jacob Moroni
2026-06-05 17:11 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605171137.GA2771195@nvidia.com \
--to=jgg@nvidia.com \
--cc=jmoroni@google.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tatyana.e.nikolova@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox