From: Jason Gunthorpe <jgg@nvidia.com>
To: Jordan Walters <jaggyaur@gmail.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/rxe: Fix use-after-free of netdev in smc_ib_port_event_work
Date: Fri, 5 Jun 2026 14:47:10 -0300 [thread overview]
Message-ID: <20260605174710.GA2790493@nvidia.com> (raw)
In-Reply-To: <20260603100919.268055-1-jaggyaur@gmail.com>
On Wed, Jun 03, 2026 at 06:09:19AM -0400, Jordan Walters wrote:
> @@ -663,6 +663,7 @@ void rxe_net_del(struct ib_device *dev)
> if (sk)
> rxe_sock_put(sk, rxe_ns_pernet_set_sk6, net);
>
> + ib_device_set_netdev(dev, NULL, 1);
> dev_put(ndev);
None of how rxe is handling the netdev seems to be correct at all.
The affiliated netdev of an IB device cannot be unrefed until the ib
device itself is destroyed, the above is just more racy wrongness even
if it makes the splat go away.
rxe_net_del() needs to be deleted, not patched.
I'm getting very fed up with all this RXE garbage, it has got a lot
worse lately with all these attempts to "improve" it and I don't want
to be looking at this endless stream of bugs reports.
and zhu don't send me any more AI written emails.
Jason
prev parent reply other threads:[~2026-06-05 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 10:09 [PATCH] RDMA/rxe: Fix use-after-free of netdev in smc_ib_port_event_work Jordan Walters
2026-06-04 1:42 ` Zhu Yanjun
2026-06-05 17:47 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605174710.GA2790493@nvidia.com \
--to=jgg@nvidia.com \
--cc=jaggyaur@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox