From: Selvin Xavier <selvin.xavier@broadcom.com>
To: leon@kernel.org, jgg@ziepe.ca
Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com,
kalesh-anakkur.purayil@broadcom.com,
sriharsha.basavapatna@broadcom.com,
Selvin Xavier <selvin.xavier@broadcom.com>
Subject: [PATCH 05/11] RDMA/bnxt_re: Add a max slot check for SQ
Date: Wed, 10 Jun 2026 03:08:49 -0700 [thread overview]
Message-ID: <20260610100855.64212-6-selvin.xavier@broadcom.com> (raw)
In-Reply-To: <20260610100855.64212-1-selvin.xavier@broadcom.com>
The variable WQE mode must be validated against
the maximum slots supported by HW. The max supported
value is 64K. Adding a max check and fail if user
supplied value is more than the max supported.
Fixes: d8ea645d6984 ("RDMA/bnxt_re: Handle variable WQE support for user applications")
Reviewed-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 3 +++
drivers/infiniband/hw/bnxt_re/qplib_sp.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index eed918b9cdf1..eb428d2409d6 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -1748,6 +1748,9 @@ static int bnxt_re_init_qp_attr(struct bnxt_re_qp *qp, struct bnxt_re_pd *pd,
return qptype;
qplqp->type = (u8)qptype;
qplqp->wqe_mode = bnxt_re_is_var_size_supported(rdev, uctx);
+ if (uctx && qplqp->wqe_mode == BNXT_QPLIB_WQE_MODE_VARIABLE &&
+ ureq->sq_slots > BNXT_RE_MAX_SQ_SLOTS)
+ return -EINVAL;
if (fixed_que_attr) {
if (qplqp->wqe_mode != BNXT_QPLIB_WQE_MODE_VARIABLE)
return -EOPNOTSUPP;
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.h b/drivers/infiniband/hw/bnxt_re/qplib_sp.h
index 9fadd637cb5b..c4193ae75b54 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_sp.h
+++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.h
@@ -369,6 +369,7 @@ int bnxt_qplib_destroy_flow(struct bnxt_qplib_res *res);
#define BNXT_VAR_MAX_SLOT_ALIGN 256
#define BNXT_VAR_MAX_SGE 13
#define BNXT_RE_MAX_RQ_WQES 65536
+#define BNXT_RE_MAX_SQ_SLOTS 65536
#define BNXT_STATIC_MAX_SGE 6
--
2.39.3
next prev parent reply other threads:[~2026-06-10 4:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 10:08 [PATCH 00/11] RDMA/bnxt_re: Generic driver fixes Selvin Xavier
2026-06-10 10:08 ` [PATCH 01/11] RDMA/bnxt_re : Initialize dpi variable to zero Selvin Xavier
2026-06-10 10:08 ` [PATCH 02/11] RDMA/bnxt_re: Add ownership check while getting the CQ toggle page Selvin Xavier
2026-06-10 10:08 ` [PATCH 03/11] RDMA/bnxt_re: Add ownership check while getting the SRQ " Selvin Xavier
2026-06-10 10:08 ` [PATCH 04/11] RDMA/bnxt_re: Avoid displaying the kernel pointer Selvin Xavier
2026-06-10 10:08 ` Selvin Xavier [this message]
2026-06-10 10:08 ` [PATCH 06/11] RDMA/bnxt_re: Avoid repeated requests to allocate WC pages Selvin Xavier
2026-06-10 6:19 ` Selvin Xavier
2026-06-10 10:08 ` [PATCH 07/11] RDMA/bnxt_re: Avoid any race while handling the hash list of CQ Selvin Xavier
2026-06-10 10:08 ` [PATCH 08/11] RDMA/bnxt_re: Avoid any race while handling the hash list of SRQ Selvin Xavier
2026-06-10 10:08 ` [PATCH 09/11] RDMA/bnxt_re: Fix the cleanup upon error during srq create Selvin Xavier
2026-06-10 10:08 ` [PATCH 10/11] RDMA/bnxt_re: Fix the cleanup upon error during CQ create Selvin Xavier
2026-06-10 10:08 ` [PATCH 11/11] RDMA/bnxt_re: Fail DBR related page allocation UAPIs if the feature is disabled Selvin Xavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610100855.64212-6-selvin.xavier@broadcom.com \
--to=selvin.xavier@broadcom.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=jgg@ziepe.ca \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox