From: Jason Gunthorpe <jgg@nvidia.com>
To: Jacob Moroni <jmoroni@google.com>
Cc: tatyana.e.nikolova@intel.com, leon@kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/irdma: Replace waitqueue and flag with completion
Date: Tue, 16 Jun 2026 16:07:59 -0300 [thread overview]
Message-ID: <20260616190759.GC3986358@nvidia.com> (raw)
In-Reply-To: <20260616155601.1081448-1-jmoroni@google.com>
On Tue, Jun 16, 2026 at 03:56:01PM +0000, Jacob Moroni wrote:
> The driver previously used a waitqueue along with an explicit
> request_done flag, but without proper barriers around request_done.
>
> An earlier patch by Gui-Dong Han <hanguidong02@gmail.com> attempted
> to fix this by adding the missing memory barriers. Rather than
> adding the barriers, this patch replaces the waitqueue+flag with
> a completion, which is designed for this exact purpose.
>
> Link: https://lore.kernel.org/linux-rdma/20260604135513.GU2487554@ziepe.ca/T/#t
> Fixes: 44d9e52977a1 ("RDMA/irdma: Implement device initialization definitions")
> Fixes: 915cc7ac0f8e ("RDMA/irdma: Add miscellaneous utility definitions")
> Signed-off-by: Jacob Moroni <jmoroni@google.com>
> ---
> drivers/infiniband/hw/irdma/hw.c | 7 +++----
> drivers/infiniband/hw/irdma/main.h | 3 +--
> drivers/infiniband/hw/irdma/utils.c | 12 +++++-------
> 3 files changed, 9 insertions(+), 13 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2026-06-16 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 15:56 [PATCH rdma-next] RDMA/irdma: Replace waitqueue and flag with completion Jacob Moroni
2026-06-16 19:07 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616190759.GC3986358@nvidia.com \
--to=jgg@nvidia.com \
--cc=jmoroni@google.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tatyana.e.nikolova@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox