From: Jason Gunthorpe <jgg@nvidia.com>
To: Chenguang Zhao <chenguang.zhao@linux.dev>
Cc: leon@kernel.org, edwards@nvidia.com, michaelgur@nvidia.com,
vdumitrescu@nvidia.com, jiri@resnulli.us,
linux-rdma@vger.kernel.org,
Chenguang Zhao <zhaochenguang@kylinos.cn>
Subject: Re: [PATCH] RDMA/core: quiesce CQ polling before device shutdown on reboot
Date: Thu, 2 Jul 2026 14:40:27 -0300 [thread overview]
Message-ID: <20260702174027.GA1518125@nvidia.com> (raw)
In-Reply-To: <20260702073422.279820-1-chenguang.zhao@linux.dev>
On Thu, Jul 02, 2026 at 03:34:22PM +0800, Chenguang Zhao wrote:
> On forced reboot (reboot -f), mlx5 may enter shutdown while ib-comp-wq
> still polls live CQs, causing use-after-free in wr_cqe->done(). Drain
> completion workqueues from the kernel reboot path before device_shutdown()
> via a function pointer hook, and guard CQ processing during shutdown.
I think this is a bug in mlx5, it should not be destroying things
other parts of the kernel depend on during its shutdown. The real purpose
of shutdown is to DMA quite the device so the kdump kernel can recover
it and use it as the kdump NIC.
Jason
prev parent reply other threads:[~2026-07-02 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 7:34 [PATCH] RDMA/core: quiesce CQ polling before device shutdown on reboot Chenguang Zhao
2026-07-02 17:40 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702174027.GA1518125@nvidia.com \
--to=jgg@nvidia.com \
--cc=chenguang.zhao@linux.dev \
--cc=edwards@nvidia.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@nvidia.com \
--cc=vdumitrescu@nvidia.com \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox