From: Jason Gunthorpe <jgg@ziepe.ca>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, shirazsaleem@microsoft.com,
longli@microsoft.com, leon@kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Adopt robust udata
Date: Thu, 2 Jul 2026 15:01:58 -0300 [thread overview]
Message-ID: <20260702180158.GU7525@ziepe.ca> (raw)
In-Reply-To: <20260623114444.1429042-1-kotaranov@linux.microsoft.com>
On Tue, Jun 23, 2026 at 04:44:43AM -0700, Konstantin Taranov wrote:
> +struct mana_ib_uctx_req {
> + __aligned_u64 client_caps1;
> + __aligned_u64 client_caps2;
> + __aligned_u64 client_caps3;
> + __aligned_u64 client_caps4;
> + __aligned_u64 comp_mask;
> +};
I think Jacob has it right, This is looking pretty gross.
If you want such a complex protocol then use the new ioctl format and
declare sensible driver specific attributes. Nobody has converted
alloc_ucontext yet, but that is usually not hard to do.
Then you can use the existing mandatory/optional schemes to pass
whatever is appropriate with full easy compat.
So maybe split this part out, the rst of the udata fiddling looks OK
Jason
next prev parent reply other threads:[~2026-07-02 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 11:44 [PATCH rdma-next 1/1] RDMA/mana_ib: Adopt robust udata Konstantin Taranov
2026-06-23 12:23 ` Jacob Moroni
2026-06-25 8:55 ` Konstantin Taranov
2026-06-25 13:29 ` Jacob Moroni
2026-06-25 13:50 ` Konstantin Taranov
2026-07-02 18:01 ` Jason Gunthorpe [this message]
2026-07-10 8:54 ` Konstantin Taranov
2026-07-10 12:52 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702180158.GU7525@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=kotaranov@linux.microsoft.com \
--cc=kotaranov@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=shirazsaleem@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox