From: Leon Romanovsky <leon@kernel.org>
To: Jacob Moroni <jmoroni@google.com>, jgg@ziepe.ca
Cc: tatyana.e.nikolova@intel.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next 3/5] RDMA/irdma: Use ib_respond_empty_udata where applicable
Date: Sun, 5 Jul 2026 15:14:54 +0300 [thread overview]
Message-ID: <20260705121454.GC15188@unreal> (raw)
In-Reply-To: <20260627025642.4064973-4-jmoroni@google.com>
On Sat, Jun 27, 2026 at 02:56:40AM +0000, Jacob Moroni wrote:
> Methods that do not provide any user response should use
> the ib_respond_empty_udata() helper to ensure that user
> response buffers are cleared.
>
> Signed-off-by: Jacob Moroni <jmoroni@google.com>
> ---
> drivers/infiniband/hw/irdma/verbs.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
> index 19dcc475c355..d06df520d9be 100644
> --- a/drivers/infiniband/hw/irdma/verbs.c
> +++ b/drivers/infiniband/hw/irdma/verbs.c
> @@ -457,7 +457,7 @@ static int irdma_dealloc_pd(struct ib_pd *ibpd, struct ib_udata *udata)
>
> irdma_free_rsrc(iwdev->rf, iwdev->rf->allocated_pds, iwpd->sc_pd.pd_id);
>
> - return 0;
> + return ib_respond_empty_udata(udata);
I wonder how this is supposed to work. What should the user do
after hitting this error? Retry the operation? The object has
already been deallocated.
Thanks.
next prev parent reply other threads:[~2026-07-05 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 2:56 [PATCH rdma-next 0/5] RDMA/irdma: Adopt robust udata Jacob Moroni
2026-06-27 2:56 ` [PATCH rdma-next 1/5] RDMA/irdma: Enforce empty udata input for no-input ops Jacob Moroni
2026-06-27 2:56 ` [PATCH rdma-next 2/5] RDMA/irdma: Use robust udata input copy helpers Jacob Moroni
2026-06-27 2:56 ` [PATCH rdma-next 3/5] RDMA/irdma: Use ib_respond_empty_udata where applicable Jacob Moroni
2026-07-05 12:14 ` Leon Romanovsky [this message]
2026-07-05 20:09 ` Jacob Moroni
2026-06-27 2:56 ` [PATCH rdma-next 4/5] RDMA/irdma: Use robust udata helper for QP creation Jacob Moroni
2026-06-27 2:56 ` [PATCH rdma-next 5/5] RDMA/irdma: Enable uverbs_robust_udata compliance flag Jacob Moroni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260705121454.GC15188@unreal \
--to=leon@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jmoroni@google.com \
--cc=linux-rdma@vger.kernel.org \
--cc=tatyana.e.nikolova@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox