From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDFE243B3FA for ; Fri, 10 Jul 2026 16:43:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783701795; cv=none; b=XweRBJMGgy5Brg862Mom6oo+gpB2p8JS3WWERSJYNIRbz7vPBPI9fPBOjyBfAnyhYmMsxhqaNY4bkwDQnMc2Kjkb6ipUlVBBq60Ox2iYNKP4Y/6CMyEtuoPzjpfdry6azzhsGfNXf2ECE96A0M58u7/Cgm91kE0dmKSVRRucrX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783701795; c=relaxed/simple; bh=ZL2zX2D9UZwwCtPCpSQDsF4TpGKLC8vJlz83DhiVqG4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=isuunAmyjS1UDFRMUVyAuFUbOF5+wzfjgNE66yVUxkMWqq8+H9WmZYlGjNAhVtZDIdPYMRAwLV6FKZt1GfzmGA0y6FeehwpYaUTBLyhDTNeA7kQ1u1aALNXpmMVltQ0jbOjXBjVY/UZEkpFk3K7nyEZ/PQcxR3x5f7HHS8D0Njo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=MTVA1wSc; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="MTVA1wSc" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-902f92b8504so5357246d6.2 for ; Fri, 10 Jul 2026 09:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1783701793; x=1784306593; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=cCrA5GvcNcomQ8YHAskvpnsx6mUAVwyB/JWdGkfbiJc=; b=MTVA1wScQzJ9mlsaDCFYAeIc6xDO4WA4Ha4RmRKgQuysCFeal1CB14Sstfu4qFZ55f 5cmlur51RFp7E08XP0GP0n+sZtz0fWTWn9KAeT+6cdTgXgk34jVkAL2//BWc+AE0eh/o pVATPDZeP9aLep4mUYpOaw5F8BtOjdTkDlFFtCYDYFB30W/Ghd/j3osldimeaWfpiVXF eWKYnURUzVLAc1nLwCsM4FJLlramamUsaud7zt/S+jZKmlI4H5rpUl06VdgG6YIGp1PF bBsToAihc8O4hRIFyPSAuyBXyTdFTL5VmCtZBBTfB+Qaq1KgIVsfqYJIuAv6sv+JXdkA wJGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783701793; x=1784306593; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cCrA5GvcNcomQ8YHAskvpnsx6mUAVwyB/JWdGkfbiJc=; b=YTGzVSdlIobHmungzzQoB5emCLbZy69RLcz+J7FX6C5/oHtr/dvIB+vPjds7B1CbE2 86HPiOJANCQljeKVGMy3GAXhcUD3QkCU9qJ1zlX9ueYbs8dMdKrdJkksdiCvyzQB0tCT goI/QuqHE+5sGdZsXghTglbTObL9+zNU13wUIVuU5ep2YaiRlv7HFVt3y5CUUX+NmoCe SNyZ75Rm/LoTlpWmDtidWs8Lfq/fcdoZ1Y6RWAQPohaeEGQ2K+6+isSNki4IDnHdC6bv kNWRpkcfLIDJw7NP9d18fyccjyV6Sm+hL2wkqlLgpUE5lTdZ9ekEfmeKDF1PAf7kj3oK PslQ== X-Forwarded-Encrypted: i=1; AHgh+RrYOoSjfDrHgAu+n6OFQLYvsg88+pFPtvN60qstb5q9yzVdm7JM9CRzb4F56hrzUfn2gKLvFwctM6Td@vger.kernel.org X-Gm-Message-State: AOJu0Ywm3SEPiATNMZpUL8286/LbtbW/RrUXmdAH2PmuajHe8BgVKPHn 2FYGP++yRSDL4PC5eR3CqVHVRemzOV+NnCsDdQKKMtSeMST7I3y7wRUBsvy6yGKZiaA= X-Gm-Gg: AfdE7cmSi9ViwpXYP7T4CNSxTL9tPhcsMGb9IcnMZ4t1ay2WoKV7xVlvD4+MqmLPXzG F8A4R0Bc0om1CUpHq429o2EFEU1fz8L53Jc56bWcWiqLkBfDUSTbQcG1P7BNjAiiQn9DhKfih6c Osy4GLAlGh2r4xoNnihqPcw1R0wgkKwZ//QtLv+ZIVSWjV72wZJBw+y1I2q7rb7IW/eM5f6XLNK TWNezyf+lLnlJ0v4bG6uD1T3OyDelYe5GYkAZY5CAROe6qn3wPUMeCbgZFTEGHUWjMeRJ08KrXW +6Yt9gHqjMEw2Mz4oWW6hzDrEu3Y6CV5zxzN0NnW/lX0VaO/O+F4OfSIlDMwfAoaBM2HKF1M5Tp DxLhk67bclCe0mcPqJSuX4pTgnx5b87SPTHXn8a0FPshhrhCy8pDeSwRYwwer X-Received: by 2002:a05:6214:43c8:b0:8f4:4d6:8adb with SMTP id 6a1803df08f44-8fec1d808a6mr146369176d6.22.1783701792723; Fri, 10 Jul 2026 09:43:12 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-900a7f8f5d6sm30725036d6.15.2026.07.10.09.43.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 09:43:12 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wiEJj-00000007Yof-1AFg; Fri, 10 Jul 2026 13:43:11 -0300 Date: Fri, 10 Jul 2026 13:43:11 -0300 From: Jason Gunthorpe To: Stanislav Kinsburskii Cc: airlied@gmail.com, akhilesh@ee.iitb.ac.in, akpm@linux-foundation.org, corbet@lwn.net, dakr@kernel.org, david@kernel.org, decui@microsoft.com, haiyangz@microsoft.com, kees@kernel.org, kys@microsoft.com, leon@kernel.org, liam@infradead.org, lizhi.hou@amd.com, ljs@kernel.org, longli@microsoft.com, lyude@redhat.com, maarten.lankhorst@linux.intel.com, mamin506@gmail.com, mhocko@suse.com, mripard@kernel.org, nouveau@lists.freedesktop.org, ogabbay@kernel.org, oleg@redhat.com, rppt@kernel.org, shuah@kernel.org, simona@ffwll.ch, skhan@linuxfoundation.org, surenb@google.com, tzimmermann@suse.de, vbabka@kernel.org, wei.liu@kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v7 6/8] RDMA/umem: Use hmm_range_fault_unlocked_timeout() for ODP faults Message-ID: <20260710164311.GU118978@ziepe.ca> References: <178345345668.660027.2952911919681614557.stgit@skinsburskii> <178345364975.660027.8790629832830633290.stgit@skinsburskii> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178345364975.660027.8790629832830633290.stgit@skinsburskii> On Tue, Jul 07, 2026 at 12:47:29PM -0700, Stanislav Kinsburskii wrote: > ib_umem_odp_map_dma_and_lock() takes mmap_read_lock() only around > hmm_range_fault(), then retries -EBUSY until HMM_RANGE_DEFAULT_TIMEOUT > expires. > > Use hmm_range_fault_unlocked_timeout() instead. The HMM helper now owns > the mmap lock and refreshes range->notifier_seq for its internal retries. > ODP keeps using HMM_RANGE_DEFAULT_TIMEOUT for each HMM fault attempt, > while interval invalidation retries continue to be handled by the existing > outer loop. > > ODP still validates the interval notifier sequence while holding umem_mutex > before DMA mapping pages. > > Signed-off-by: Stanislav Kinsburskii > --- > drivers/infiniband/core/umem_odp.c | 18 +++++------------- > 1 file changed, 5 insertions(+), 13 deletions(-) Reviewed-by: Jason Gunthorpe Jason