Re: [PATCH rdma-rc 0/2] RDMA/ionic: Fix NULL pointer dereferences

[Leon Romanovsky <leon@kernel.org>]

On Sun, Jul 12, 2026 at 03:30:09PM -0400, Kamal Heib wrote:
> On Sun, Jul 12, 2026 at 12:13:26PM +0300, Leon Romanovsky wrote:
> > On Thu, Jul 09, 2026 at 06:03:51PM -0400, Kamal Heib wrote:
> > > Fix two potential NULL pointer dereferences in the ionic driver by
> > > adding the missing NULL checks before dereferencing netdev pointers.
> > 
> > How is it possible to have ionic IB driver without netdev?
> > 
> > Thanks
> >
> 
> Thanks for your review, after taking a deeper look:
> 
> For Patch 2 (ionic_create_ibdev): You are right. Since lif is embedded in
> netdev via netdev_priv() and they are allocated/freed together,
> lif->netdev cannot be NULL if lif is valid, Please drop this patch.
> 
> For Patch 1 (ionic_query_device): This one should remain.
> ib_device_get_netdev() is a core RDMA API that explicitly returns NULL in
> multiple code paths:
> 
> - Invalid port: if (!rdma_is_port_valid(ib_dev, port)) return NULL;
> - No port_data: if (!ib_dev->port_data) return NULL;
> - NULL netdev pointer stored in port_data
> 
> Also, the return value from ib_device_get_netdev() is being checked in
> multiple places in both drivers and the RDMA core.
> 
> Let me know what you think?

I think that you shouldn't copy/paste answers from your favorite AI tool.

Thanks

> 
> Thanks,
> Kamal
> 
> > > 
> > > Kamal Heib (2):
> > >   RDMA/ionic: Fix potential NULL pointer dereference in
> > >     ionic_query_device
> > >   RDMA/ionic: Fix potential NULL pointer dereference in
> > >     ionic_create_ibdev
> > > 
> > >  drivers/infiniband/hw/ionic/ionic_ibdev.c | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > > 
> > > -- 
> > > 2.55.0
> > > 
> > > 
> > 
>