From: Leon Romanovsky <leon@kernel.org>
To: Michael Margolin <mrgolin@amazon.com>
Cc: jgg@nvidia.com, linux-rdma@vger.kernel.org, sleybo@amazon.com,
matua@amazon.com, gal.pressman@linux.dev
Subject: Re: [PATCH for-next v8 0/5] Introduce Completion Counters
Date: Thu, 16 Jul 2026 11:29:34 +0300 [thread overview]
Message-ID: <20260716082934.GB70906@unreal> (raw)
In-Reply-To: <20260715073958.GA21197@dev-dsk-mrgolin-1c-b2091117.eu-west-1.amazon.com>
On Wed, Jul 15, 2026 at 07:39:58AM +0000, Michael Margolin wrote:
> On Wed, Jul 08, 2026 at 12:36:40PM +0000, Michael Margolin wrote:
> > On Tue, Jul 07, 2026 at 08:34:22PM +0000, Michael Margolin wrote:
> > > Add core infrastructure for Completion Counters, a light-weight
> > > alternative to polling CQ for tracking operation completions. The
> > > related rdma-core support is linked in [1].
> > >
> > > Define the UVERBS_OBJECT_COMP_CNTR ioctl object with create, destroy,
> > > modify and read methods for both success and error counters. Add a QP
> > > attach method on the QP object to associate a completion counter with a
> > > queue pair.
> > >
> > > Add EFA Completion Counters support as first implementer.
> > >
> > > [1] https://github.com/linux-rdma/rdma-core/pull/1701
> > >
> >
> > Walked over Sashiko's comments, most of them are about usage count
> > which is handled in a follow-up patch in the series. The others don't
> > seem to be real issues.
> >
> > https://sashiko.dev/#/patchset/20260707203427.6923-1-mrgolin%40amazon.com
> >
> > Jason, Leon do you have any other comments?
> >
> > Michael
> >
>
> I need your feedback on this series, specifically on the ABI changes
> (and libibverbs), to unblock progress in upper layers that depend on
> this support (libfabric, NCCL).
We are primarily waiting for the relevant rdma-core PR to be ready.
Thanks
prev parent reply other threads:[~2026-07-16 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 20:34 [PATCH for-next v8 0/5] Introduce Completion Counters Michael Margolin
2026-07-07 20:34 ` [PATCH for-next v8 1/5] RDMA/core: Add Completion Counters support Michael Margolin
2026-07-07 20:34 ` [PATCH for-next v8 2/5] RDMA/core: Prevent destroying in-use completion counters Michael Margolin
2026-07-07 20:34 ` [PATCH for-next v8 3/5] RDMA/core: Add Completion Counters to resource tracking Michael Margolin
2026-07-07 20:34 ` [PATCH for-next v8 4/5] RDMA/efa: Update device interface Michael Margolin
2026-07-07 20:34 ` [PATCH for-next v8 5/5] RDMA/efa: Add Completion Counters support Michael Margolin
2026-07-08 12:36 ` [PATCH for-next v8 0/5] Introduce Completion Counters Michael Margolin
2026-07-15 7:39 ` Michael Margolin
2026-07-16 8:29 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716082934.GB70906@unreal \
--to=leon@kernel.org \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox