Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/umem: Fix the ib_umem_dmabuf_get() prototype
Date: Mon, 20 Jul 2026 16:01:58 +0300	[thread overview]
Message-ID: <20260720130158.GF110966@unreal> (raw)
In-Reply-To: <f450b272eff7c0f0d3c1a5f08d27ebc042704f76.1784495762.git.christophe.jaillet@wanadoo.fr>

On Sun, Jul 19, 2026 at 11:16:17PM +0200, Christophe JAILLET wrote:
> If CONFIG_INFINIBAND_USER_MEM is not defined, then the last parameter of
> ib_umem_dmabuf_get() is missing a const qualifier in order to match its
> prototype.
> 
> This is an issue since commit dcae56cfecc6 ("RDMA/mlx5: Constify struct
> ib_frmr_pool_ops and dma_buf_attach_ops") because now a "const struct
> dma_buf_attach_ops *o" can really be passed to the function.
> 
> Fixes: dcae56cfecc6 ("RDMA/mlx5: Constify struct ib_frmr_pool_ops and dma_buf_attach_ops")

I squashed that fix to the problematic commit.

Thanks

> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  include/rdma/ib_umem.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/rdma/ib_umem.h b/include/rdma/ib_umem.h
> index 31b3a86fe73a..1fe87fd1d769 100644
> --- a/include/rdma/ib_umem.h
> +++ b/include/rdma/ib_umem.h
> @@ -250,7 +250,7 @@ struct ib_umem_dmabuf *ib_umem_dmabuf_get(struct ib_device *device,
>  					  unsigned long offset,
>  					  size_t size, int fd,
>  					  int access,
> -					  struct dma_buf_attach_ops *ops)
> +					  const struct dma_buf_attach_ops *ops)
>  {
>  	return ERR_PTR(-EOPNOTSUPP);
>  }
> -- 
> 2.55.0
> 

      reply	other threads:[~2026-07-20 13:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-19 21:16 [PATCH] RDMA/umem: Fix the ib_umem_dmabuf_get() prototype Christophe JAILLET
2026-07-20 13:01 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260720130158.GF110966@unreal \
    --to=leon@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jgg@ziepe.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox