From: Yonatan Nachum <ynachum@amazon.com>
To: <jgg@nvidia.com>, <leon@kernel.org>, <linux-rdma@vger.kernel.org>
Cc: <mrgolin@amazon.com>, <sleybo@amazon.com>, <matua@amazon.com>,
<gal.pressman@linux.dev>, <danamala@amazon.com>,
Chen Brasch <cbrasch@amazon.com>,
Yonatan Nachum <ynachum@amazon.com>
Subject: [PATCH for-next 1/2] RDMA/efa: Use device ABI MR permissions instead of verbs flags
Date: Thu, 6 Aug 2026 07:57:57 +0000 [thread overview]
Message-ID: <20260806075758.3476667-2-ynachum@amazon.com> (raw)
In-Reply-To: <20260806075758.3476667-1-ynachum@amazon.com>
From: Dana Malachi <danamala@amazon.com>
Set MR permissions explicitly using device interface definitions rather
than copying raw verbs access flags. This is needed for the next
commit, to allow access flag bits that are not in the permissions field.
Reviewed-by: Chen Brasch <cbrasch@amazon.com>
Reviewed-by: Michael Margolin <mrgolin@amazon.com>
Signed-off-by: Dana Malachi <danamala@amazon.com>
Signed-off-by: Yonatan Nachum <ynachum@amazon.com>
---
drivers/infiniband/hw/efa/efa_com_cmd.c | 7 ++++++-
drivers/infiniband/hw/efa/efa_com_cmd.h | 7 +++++--
drivers/infiniband/hw/efa/efa_verbs.c | 4 +++-
3 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/efa/efa_com_cmd.c b/drivers/infiniband/hw/efa/efa_com_cmd.c
index 1b00f16b8ea8..aac0e936601a 100644
--- a/drivers/infiniband/hw/efa/efa_com_cmd.c
+++ b/drivers/infiniband/hw/efa/efa_com_cmd.c
@@ -237,7 +237,12 @@ int efa_com_register_mr(struct efa_com_dev *edev,
EFA_SET(&mr_cmd.flags, EFA_ADMIN_REG_MR_CMD_PHYS_PAGE_SIZE_SHIFT,
params->page_shift);
mr_cmd.iova = params->iova;
- mr_cmd.permissions = params->permissions;
+ if (params->permissions.local_write)
+ EFA_SET(&mr_cmd.permissions, EFA_ADMIN_REG_MR_CMD_LOCAL_WRITE_ENABLE, 1);
+ if (params->permissions.remote_write)
+ EFA_SET(&mr_cmd.permissions, EFA_ADMIN_REG_MR_CMD_REMOTE_WRITE_ENABLE, 1);
+ if (params->permissions.remote_read)
+ EFA_SET(&mr_cmd.permissions, EFA_ADMIN_REG_MR_CMD_REMOTE_READ_ENABLE, 1);
if (params->inline_pbl) {
memcpy(mr_cmd.pbl.inline_pbl_array,
diff --git a/drivers/infiniband/hw/efa/efa_com_cmd.h b/drivers/infiniband/hw/efa/efa_com_cmd.h
index bca722f021ea..7b0399811cfd 100644
--- a/drivers/infiniband/hw/efa/efa_com_cmd.h
+++ b/drivers/infiniband/hw/efa/efa_com_cmd.h
@@ -204,8 +204,11 @@ struct efa_com_reg_mr_params {
* address mapping
*/
u8 page_shift;
- /* see permissions field of struct efa_admin_reg_mr_cmd */
- u8 permissions;
+ struct {
+ u8 local_write : 1;
+ u8 remote_write : 1;
+ u8 remote_read : 1;
+ } permissions;
u8 inline_pbl;
u8 indirect;
};
diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c
index 2d28d68efe77..635687275350 100644
--- a/drivers/infiniband/hw/efa/efa_verbs.c
+++ b/drivers/infiniband/hw/efa/efa_verbs.c
@@ -1676,7 +1676,9 @@ static int efa_register_mr(struct ib_pd *ibpd, struct efa_mr *mr, u64 start,
params.pd = to_epd(ibpd)->pdn;
params.iova = virt_addr;
params.mr_length_in_bytes = length;
- params.permissions = access_flags;
+ params.permissions.local_write = !!(access_flags & IB_ACCESS_LOCAL_WRITE);
+ params.permissions.remote_write = !!(access_flags & IB_ACCESS_REMOTE_WRITE);
+ params.permissions.remote_read = !!(access_flags & IB_ACCESS_REMOTE_READ);
pg_sz = ib_umem_find_best_pgsz(mr->umem,
dev->dev_attr.page_size_cap,
--
2.50.1
next prev parent reply other threads:[~2026-08-06 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 7:57 [PATCH for-next 0/2] RDMA/efa: Add support for MR relaxed ordering Yonatan Nachum
2026-08-06 7:57 ` Yonatan Nachum [this message]
2026-08-06 7:57 ` [PATCH for-next 2/2] RDMA/efa: Pass relaxed ordering flag to device Yonatan Nachum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806075758.3476667-2-ynachum@amazon.com \
--to=ynachum@amazon.com \
--cc=cbrasch@amazon.com \
--cc=danamala@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox