From: Jason Gunthorpe <jgg@ziepe.ca>
To: Krystian Kaniewski <krystianmkaniewski@gmail.com>
Cc: Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com,
syzbot+5fe14f2ff4ccbace9a26@syzkaller.appspotmail.com
Subject: Re: [PATCH net v3] RDMA/core: Reject unregistering netdevs in ib_get_eth_speed
Date: Mon, 10 Aug 2026 10:42:35 -0300 [thread overview]
Message-ID: <20260810134235.GO200537@ziepe.ca> (raw)
In-Reply-To: <20260810133124.44513-1-krystianmkaniewski@gmail.com>
On Mon, Aug 10, 2026 at 03:31:20PM +0200, Krystian Kaniewski wrote:
> @@ -2049,7 +2050,15 @@ int ib_get_eth_speed(struct ib_device *dev, u32 port_num, u16 *speed, u8 *width)
> return -ENODEV;
>
> rtnl_lock();
> + if (READ_ONCE(netdev->reg_state) != NETREG_REGISTERED) {
> + dev_put(netdev);
> + rtnl_unlock();
> + return -ENODEV;
> + }
> +
> rc = __ethtool_get_link_ksettings(netdev, &lksettings);
> + if (rc)
> + strscpy(name, netdev->name, sizeof(name));
> rtnl_unlock();
>
> dev_put(netdev);
> @@ -2060,7 +2069,7 @@ int ib_get_eth_speed(struct ib_device *dev, u32 port_num, u16 *speed, u8 *width)
> netdev_speed = SPEED_1000;
> if (rc)
> pr_warn("%s speed is unknown, defaulting to %u\n",
> - netdev->name, netdev_speed);
> + name, netdev_speed);
> }
I would probably just put this block inside the rtnl lock and not copy
the netdev->name
Jason
next prev parent reply other threads:[~2026-08-10 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 13:31 [PATCH net v3] RDMA/core: Reject unregistering netdevs in ib_get_eth_speed Krystian Kaniewski
2026-08-10 13:42 ` Jason Gunthorpe [this message]
2026-08-10 18:33 ` Jakub Kicinski
2026-08-10 18:39 ` Jason Gunthorpe
2026-08-11 9:21 ` Krystian Kaniewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810134235.GO200537@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=krystianmkaniewski@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+5fe14f2ff4ccbace9a26@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox