From: Jason Gunthorpe <jgg@nvidia.com>
To: Yonatan Nachum <ynachum@amazon.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org, mrgolin@amazon.com,
sleybo@amazon.com, matua@amazon.com, gal.pressman@linux.dev
Subject: Re: [PATCH for-next v2 0/3] RDMA/efa: Add support for 128B admin v2 SQ entry
Date: Tue, 11 Aug 2026 16:39:38 -0300 [thread overview]
Message-ID: <20260811193938.GA661193@nvidia.com> (raw)
In-Reply-To: <20260809192237.GA15936@dev-dsk-ynachum-1b-aa121316.eu-west-1.amazon.com>
On Sun, Aug 09, 2026 at 07:22:37PM +0000, Yonatan Nachum wrote:
>
> Hi, kind reminder for this series.
> I reviewed the Sashiko comments and they aren't correct.
They look correct to me, the stack buffers should be u64 arrays for
the alignment reason it gave.
common_v2 = (struct efa_admin_aq_common_desc_v2 *)aq_entry;
common = &common_v2->common;
common->command_id = cmd_id;
^^^^^^^^^^^^^^^^^^^
Stores u16 to an u8 aligned memory area.
You should also fix the race it pointed it.
Jason
next prev parent reply other threads:[~2026-08-11 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 7:50 [PATCH for-next v2 0/3] RDMA/efa: Add support for 128B admin v2 SQ entry Yonatan Nachum
2026-07-31 7:50 ` [PATCH for-next v2 1/3] RDMA/efa: Decouple admin command payload from admin header Yonatan Nachum
2026-07-31 7:50 ` [PATCH for-next v2 2/3] RDMA/efa: Generalize the admin SQ Yonatan Nachum
2026-07-31 7:50 ` [PATCH for-next v2 3/3] RDMA/efa: Add support for 128B admin v2 SQ entry Yonatan Nachum
2026-08-09 19:22 ` [PATCH for-next v2 0/3] " Yonatan Nachum
2026-08-11 19:39 ` Jason Gunthorpe [this message]
2026-08-12 6:58 ` Yonatan Nachum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811193938.GA661193@nvidia.com \
--to=jgg@nvidia.com \
--cc=gal.pressman@linux.dev \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox