From: Jason Gunthorpe <jgg@nvidia.com>
To: David Matlack <dmatlack@google.com>
Cc: Alex Williamson <alex@shazbot.org>,
kvm@vger.kernel.org, Leon Romanovsky <leon@kernel.org>,
linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org,
Mark Bloch <mbloch@nvidia.com>,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Shuah Khan <shuah@kernel.org>, Tariq Toukan <tariqt@nvidia.com>,
patches@lists.linux.dev
Subject: Re: [PATCH v4 06/10] vfio: selftests: Allow drivers to specify required region size
Date: Wed, 12 Aug 2026 20:44:41 -0300 [thread overview]
Message-ID: <20260812234441.GC730363@nvidia.com> (raw)
In-Reply-To: <anzvkibgzTae9eV9@google.com>
On Wed, Aug 12, 2026 at 10:11:30PM +0000, David Matlack wrote:
> > @@ -32,6 +32,9 @@ void vfio_pci_driver_probe(struct vfio_pci_device *device)
> > continue;
> >
> > device->driver.ops = ops;
> > +
> > + VFIO_ASSERT_NE(ops->region_size, 0);
> > + device->driver.region.size = ops->region_size;
>
> I'm seeing failures with the IGB driver with this series. I think it's
> coming from here. The region size needs to be page-aligned so that the
> IOMMU map/unmap calls can work?
>
> The size of struct igb is 0x20080 bytes which is not page-aligned. The
> size of struct mlx5st_device is 0x200D000, which is page-aligned, so
> that's probably why your Claude did not notice.
Makes sense, I didn't use claude for this, but it explains why my
tests passed. I've adjusted it as you showed
Jason
next prev parent reply other threads:[~2026-08-12 23:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 14:58 [PATCH v4 00/10] mlx5 support for VFIO self test Jason Gunthorpe
2026-08-12 14:58 ` [PATCH v4 01/10] net/mlx5: Add IFC structures for CQE and WQE Jason Gunthorpe
2026-08-12 14:59 ` [PATCH v4 02/10] net/mlx5: Move HW constant groups from device.h/cq.h to mlx5_ifc.h Jason Gunthorpe
2026-08-12 14:59 ` [PATCH v4 03/10] net/mlx5: Extract MLX5_SET/GET macros into mlx5_ifc_macros.h Jason Gunthorpe
2026-08-12 14:59 ` [PATCH v4 04/10] net/mlx5: Add ONCE and MMIO accessor variants to mlx5_ifc_macros.h Jason Gunthorpe
2026-08-12 14:59 ` [PATCH v4 05/10] selftests: Add additional kernel functions to tools/include/ Jason Gunthorpe
2026-08-12 14:59 ` [PATCH v4 06/10] vfio: selftests: Allow drivers to specify required region size Jason Gunthorpe
2026-08-12 22:11 ` David Matlack
2026-08-12 22:13 ` David Matlack
2026-08-12 23:44 ` Jason Gunthorpe [this message]
2026-08-12 14:59 ` [PATCH v4 07/10] vfio: selftests: Add dev_dbg Jason Gunthorpe
2026-08-12 14:59 ` [PATCH v4 08/10] vfio: selftests: Add mlx5 driver - HW init and command interface Jason Gunthorpe
2026-08-12 21:41 ` David Matlack
2026-08-12 23:32 ` Jason Gunthorpe
2026-08-12 14:59 ` [PATCH v4 09/10] vfio: selftests: Add mlx5 driver - data path and memcpy ops Jason Gunthorpe
2026-08-12 14:59 ` [PATCH v4 10/10] vfio: selftests: mlx5 driver - add send_msi support Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812234441.GC730363@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex@shazbot.org \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=saeedm@nvidia.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox