Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Yili Zhang <zhangyili01@baidu.com>
Cc: leon@kernel.org, linux-kernel@vger.kernel.org,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH 2/2] RDMA/nldev: Guard against NULL ucontext in resource dumps
Date: Wed, 12 Aug 2026 21:04:42 -0300	[thread overview]
Message-ID: <20260813000442.GI662699@ziepe.ca> (raw)
In-Reply-To: <20260812123249.44247-1-zhangyili01@baidu.com>

On Wed, Aug 12, 2026 at 08:32:49PM +0800, Yili Zhang wrote:
> Hi Jason,
> 
> Thanks for the review.  After re-reading your feedback and re-examining
> the crash log, I think I mis-characterized the root cause in my original
> patches.  Let me lay out what the log actually shows, because I'd like
> to get the fix on the right track.
> 
> The crash is a three-stage sequence, all from the same host
> (6.1.52 + MLNX_OFED 24.10):

You have to provide an analyis from top of tree upstream kernel if you
want help from this mailing list.

>   Stage 1 - a create_qp failure:
>     [24805924.400] mlx5_3: create_qp:3323:(pid 2758615): Create QP type 2 failed
> 
>   Stage 2 - on process exit, ib_uverbs_close() could not tear down the
>   process's CQs and fell into the DRIVER_FAILURE fallback:
>     [24805924.747] WARNING: ... rdma_core.c:945 uverbs_destroy_ufile_hw
>       Call Trace:
>         uverbs_destroy_ufile_hw
>         ib_uverbs_close
>         __fput

That's not supposed to happen.

> To be concrete about why it persists: under the current code, once the
> DRIVER_FAILURE fallback runs, the leaked object's restrack entry is
> never actively removed.  The CQ case:

And I think this was just fixed recently.

Jason

      reply	other threads:[~2026-08-13  0:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260811105623.48633-1-xVq3SwEoxhQs281bogBL>
     [not found] ` <6a7affdd.5c752b50.b00e6.7ed7SMTPIN_ADDED_BROKEN@mx.google.com>
2026-08-11 14:19   ` [PATCH 2/2] RDMA/nldev: Guard against NULL ucontext in resource dumps Jason Gunthorpe
2026-08-12 12:32     ` Yili Zhang
2026-08-13  0:04       ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813000442.GI662699@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=zhangyili01@baidu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox