Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jerome Tollet <jtollet@cisco.com>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: Jerome Tollet <jtollet@cisco.com>,
	netdev@vger.kernel.org, saeedm@nvidia.com, tariqt@nvidia.com,
	mbloch@nvidia.com, leonro@nvidia.com, daniel@iogearbox.net,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
	hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v3 2/2] net/mlx5e: Prevent stale XSK buffer release on MPWQE refill retry
Date: Mon, 24 Aug 2026 16:09:43 +0200	[thread overview]
Message-ID: <20260824140943.20665-1-jtollet@cisco.com> (raw)
In-Reply-To: <b4abc8e4-aa9e-4e92-97b8-c6a661014c16@nvidia.com>

Hi Dragos,

Agreed, thanks. I changed the patch to set all skip_release_bitmap bits in
the common error path of mlx5e_xsk_alloc_rx_mpwqe(), consistently with
mlx5e_alloc_rx_mpwqe().

I tested both early and partial allocation failures. With three consecutive
failures on the same MPWQE, the original 16 XSK buffers were released only
once. Retries observed a full bitmap, and a later successful allocation
cleared it. The partial case allocated 8 of 16 replacement buffers before
unwinding.

I also ran a 20-second AF_XDP zero-copy striding-RQ pressure test with the
clean patch. It exercised 1,575,262 XSK buffer allocation failures and
reported no invalid descriptors, WQE errors, or kernel warnings.

I'll send v4 with this change.

Thanks,
Jerome

  reply	other threads:[~2026-08-24 14:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 15:15 [PATCH net v2] net/mlx5e: Prevent stale XSK buffer release on refill retry Jerome Tollet
2026-08-21 21:37 ` [PATCH net v3 0/2] net/mlx5e: Prevent stale XSK buffer release on refill retries Jerome Tollet
2026-08-21 21:37   ` [PATCH net v3 1/2] net/mlx5e: Prevent stale XSK buffer release on refill retry Jerome Tollet
2026-08-21 21:37   ` [PATCH net v3 2/2] net/mlx5e: Prevent stale XSK buffer release on MPWQE " Jerome Tollet
2026-08-24 10:48     ` Dragos Tatulea
2026-08-24 14:09       ` Jerome Tollet [this message]
2026-08-24 17:42         ` Dragos Tatulea
2026-08-24 14:16   ` [PATCH net v4 0/2] net/mlx5e: Prevent stale XSK buffer release on refill retries Jerome Tollet
2026-08-24 14:16     ` [PATCH net v4 1/2] net/mlx5e: Prevent stale XSK buffer release on refill retry Jerome Tollet
2026-08-24 14:16     ` [PATCH net v4 2/2] net/mlx5e: Prevent stale XSK buffer release on MPWQE " Jerome Tollet
2026-08-24 17:41       ` Dragos Tatulea
2026-08-24 19:19       ` Jerome Tollet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824140943.20665-1-jtollet@cisco.com \
    --to=jtollet@cisco.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dtatulea@nvidia.com \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=sdf@fomichev.me \
    --cc=stable@vger.kernel.org \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox