Re: [PATCH net V3 1/3] net/mlx5: devcom, Base component size on linked devices

[sashiko-bot@kernel.org]

> From: Shay Drory <shayd@nvidia.com>
> 
> mlx5_devcom_comp_get_size() returns the component's kref count. That
> kref is bumped in mlx5_devcom_register_component() under comp_list_lock,
> before the comp_dev is linked onto comp_dev_list_head under comp->sem.
> The event broadcast (mlx5_devcom_locked_send_event()) walks that list.
> 
> Hence, a caller can read the expected size, but send_event won't be sent
> to all peers. In the SD group registration path, this lets a member
> broadcast its role-election event over an incomplete list, electing a
> primary that never completes the group, is never marked ready, and
> leaves the group with a stale primary.
> 
> Track the number of linked comp_devs in a dedicated counter, maintained
> under comp->sem together with the list add/remove, and return it from
> mlx5_devcom_comp_get_size().
> 
> Fixes: 9bb1ac80738a ("net/mlx5: devcom, Add component size getter")
> Signed-off-by: Shay Drory <shayd@nvidia.com>
> Reviewed-by: Akiva Goldberger <agoldberger@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915113459.3934760-1-tariqt@nvidia.com?part=1