From: sashiko-bot@kernel.org
To: "Jacob Moroni" <jmoroni@google.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/irdma: Fix erroneous -ENOMEM for large MR registration
Date: Tue, 15 Sep 2026 17:12:52 +0000 [thread overview]
Message-ID: <20260915171252.D635A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915170317.2901672-1-jmoroni@google.com>
> Commit cc8997c94bf3 ("RDMA/irdma: Refactor PBLE functions")
> replaced the explicit level1_only boolean with a bit mask
> but did not properly convert the "if (level1_only)" check
> in irdma_get_pble() to be "lvl == PBLE_LEVEL_1" and instead
> left it as "if (lvl)".
>
> User MR registration passes "lvl = PBLE_LEVEL_1 | PBLE_LEVEL_2"
> so this check always evaluates to true and causes the
> loop to bail after grabbing a single SD even if the region
> actually requires more than one SD (as is the case for
> regions larger than 1 GiB with 4k pages). As a result, these
> registrations can fail with -ENOMEM even if there are
> sufficient PBLE resources.
>
> Fixes: cc8997c94bf3 ("RDMA/irdma: Refactor PBLE functions")
> Signed-off-by: Jacob Moroni <jmoroni@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915170317.2901672-1-jmoroni@google.com?part=1
next prev parent reply other threads:[~2026-09-15 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 17:03 [PATCH] RDMA/irdma: Fix erroneous -ENOMEM for large MR registration Jacob Moroni
2026-09-15 17:12 ` sashiko-bot [this message]
2026-09-22 13:23 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915171252.D635A1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jmoroni@google.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox