Re: [PATCH net 1/2] net/mlx5: Bound the command interface drain so teardown cannot hang

[sashiko-bot@kernel.org]

> mlx5_cmd_allowed_opcode() and mlx5_cmd_change_mod() drain the command
> interface before updating a field that every in flight command reads, by
> taking every unit of cmd->vars.sem:
> 
> 	for (i = 0; i < cmd->vars.max_reg_cmds; i++)
> 		down(&cmd->vars.sem);
> 	down(&cmd->vars.pages_sem);
> 
> Since commit 8e715cd613a1 ("net/mlx5: Set command entry semaphore up once
> got index free") a unit is handed back from cmd_ent_put(), under the
> refcount that reaches zero:
> 
> 	if (ent->idx >= 0) {
> 		cmd_free_index(cmd, ent->idx);
> 		up(ent->page_queue ? &cmd->vars.pages_sem : &cmd->vars.sem);
> [ ... ]
> queue semaphore").
> 
> Fixes: 8e715cd613a1 ("net/mlx5: Set command entry semaphore up once got index free")
> Cc: stable@vger.kernel.org
> Signed-off-by: Danielle Costantino <dcostantino@meta.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915225941.554568-1-dcostantino@meta.com?part=1