From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk2-f43.google.com (mail-qk2-f43.google.com [74.125.230.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EEBF511239 for ; Fri, 18 Sep 2026 17:05:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789751131; cv=none; b=NQQFtr/zz787StHVc6VTIET4cbC14XwT2Stn/zzFURyyHhxIbiqkX/J6JHyZc+eZEL6FtoEAM6KhB0sMMk915TWeVnxrKGxZznWrm9tBUlrP6vo7Fl2U2eoLXSMIoqJO1kiPbK7T7dEjR9Vgnd2rT1I9F8qeLuDsPWUGix4aBpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789751131; c=relaxed/simple; bh=CJUtrnr9lbLTqP4H/g58GCIz+hH13m2n3S92AYR7A28=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HFSkWnlwdTv5hMPexadgCfhuSVYxrI5RSAb+Slgg4Twx9VNYUjIq5tb+z1k0mVYnpj3lGQs65HHm++ZTvhXDlr79CcNPuzbD5IGEfDZSGfIfZt+yJT09RsSeHXDPXTHbdX4x6blbVIfQNkdQ70KUwb2mmqqWJxzw7Pf+lCJ0Aw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Zz16yMCv; arc=none smtp.client-ip=74.125.230.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Zz16yMCv" Received: by mail-qk2-f43.google.com with SMTP id af79cd13be357-939109fafd7so83345285a.2 for ; Fri, 18 Sep 2026 10:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1789751128; x=1790355928; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zQcyEtFjPBr6Six+ddaDb/CoGlSZSKi7ev20pm6BxlM=; b=Zz16yMCvY0iYXnp4qSVkoFqfYheoD9f4m4mpImDpG1lBK5zjAXrDhEED+ZfgtMmKKb jys1jwEN8feW5ojbOVgRO7XgWW2iy67XVyUkEePMk5Xq6LEVrQtxqWBns2aRZejZ6kJU HZ3uRkD5CDOL6CSN2PRfm2xk3H9ERs6jPpBH6GG1MSBQXYB+kTGNA7u/HWhSBwG7Z8Zc 1GA+sGz6DLtPsTxDCzbUGJ/rXGjWsZvqLvGOJl6akUaZJu/X9tM8vqjyN91+zujqQvdc QgrytW/wV/mz66H73GTtDWEYG7ooveG8Pea/yxI0TY3AjvDlYVkLOtJPGvN28tqX534d oQLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789751128; x=1790355928; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=zQcyEtFjPBr6Six+ddaDb/CoGlSZSKi7ev20pm6BxlM=; b=NAuFBhCdJnAaDNQqB+7QPgGZNeFHUDo+1wKMN152Q4hBGyErrhcSdX8tWSAXEZNaki s6nctyuOInUEftWuiFJVQLxf758WDn4JRsV7KB8bXGPRySppiqcfEtEbsocrXyltUBm9 lhCVABxRL1hUC5Qklt9ibJRNX5I0slpljCQioO8sqKP55d1nHcnlugBM1I5K1g+0to+q axIuVMtRD2LvKtVOnJzgEZyCk9EzPOO3a/dard6E3uYB1WWpdUR7yaAOUABkKaL0fyyI WabHDFmL7sM/O/8tdZAQPMiAPoEw45r9gg589Ns5ietqdQqsUQacLTTjpWZGo+5OQg59 8nbg== X-Forwarded-Encrypted: i=1; AKwUvBzc5h6BTDrR3h29x/PeD4+HZmzzCceA0tBIPuRBmFW2HOYaMBAryYXK4K9PnjqyU5aHwVlD7eBUxCRc@vger.kernel.org X-Gm-Message-State: AFuF++mYSRkqqApkvE7QMFa1/GuN63yCrvtHpu3fh4yOKvb1rDmulSve JkUGVERJ23mh6x+vyqwCZMihaCiVJIN9bO78Eliu9fc8eDT2r3zeVbKvTq6fYcDwEfw= X-Gm-Gg: AYBFou2Jhh+0+NXLvbpQSji5v9VO012TwW/3Mq4RItCD9sdZC5JU33FPhLOOIQ/Bue1 JaoXpqlpWuMRJ0gxWHWHljiVBHxn/CqqLTIvw0z7dwUT4LFLXo64pBtcR8cnxunMa1TFKZBzSyi surDNwFXaRRkkGv+dKYFy/mzzcrdNCUbn/QGKxGJZqFr7seFZSoOIRA2v+ZQDcUPDTQMO8SlcCn 3P5ZCULdeL3hhykqQfnaXTQMZH2qEJvbnpXpJacHk0HpoGn6XVKKlklF9+8Gi5UxN/zZMQkX2q1 6qUxQDkWlthprdOGnr7RH6cf1cvjQ3lLxuipHU0VSU3zjv/+Calc29LOMlgrph6uqwP4skPsgIK bTpRhUNSr+6XOGN1icrvVp1zxYHVTa9O0iZmDRkEklBYv6zk9PjKAO07ToQ4bZNKcle5DMJcuIy 7HyHEK/I8w9aA4/TRpGUPGZtEK6D2x4bsfiVDE3ThBdT3QHw8svuZqoxKODXN7x3GCmqM8EO/fE j53560O8cW5jBNSq4lopUk0IFRsoNENirTl+UOVx4MTBxa9LeoTHtCF X-Received: by 2002:a05:620a:440d:b0:93a:83d:1d26 with SMTP id af79cd13be357-93bdc6c7741mr490404585a.32.1789751128040; Fri, 18 Sep 2026 10:05:28 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93be0cc67e6sm187224885a.5.2026.09.18.10.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 10:05:25 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1x7c1c-00000001zVZ-3Nwz; Fri, 18 Sep 2026 14:05:24 -0300 Date: Fri, 18 Sep 2026 14:05:24 -0300 From: Jason Gunthorpe To: Thomas =?utf-8?Q?Hellstr=C3=B6m?= Cc: Leon Romanovsky , Bjorn Helgaas , Logan Gunthorpe , Chaitanya Kulkarni , Greg Kroah-Hartman , Jens Axboe , Alex Williamson , Ankit Agrawal , Jonathan Corbet , Shuah Khan , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Randy Dunlap , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, iommu@lists.linux.dev, Tushar Dave , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-rdma@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v6 18/18] RDMA/mlx5: Ask P2PDMA whether ATS takes a direct peer-to-peer route Message-ID: <20260918170524.GH11599@ziepe.ca> References: <20260914-fix-p2p-acs-v4-0-v6-0-5ef07ec9ef06@nvidia.com> <20260914-fix-p2p-acs-v4-0-v6-18-5ef07ec9ef06@nvidia.com> <321890690ce83d1943b2f678bd9bee9b8c895b66.camel@linux.intel.com> <20260918121500.GV13683@unreal> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Sep 18, 2026 at 03:42:28PM +0200, Thomas Hellström wrote: > > 1) Xe attachment check if pci_p2pdma_distance() returns OK for the > path. Then Xe always sets up dma-addresses using dma_map_resource(). Open coding pci_p2pdma_distance() in drivers is a hack. Using dma_map_resource() like this was never "allowed". We've fixed things so these hacks are not needed, the drivers need to move over to things like dma_buf_phys_vec_to_sgt() and the hmm helpers to use the DMA API correctly. > 1a) Let's say the importer (Xe) has ATS enabled, and the exporter is > supposed to map dma_addresses. > In between there is a switch that allows direct traffic. > Now with your patch series, How would the exporter know that Xe has ATS > enabled and therefore should return IOVA mappings rather than the BUS > addresses representing the shortcut. The thing that does the DMA map must be aware of what PCI TLPs the PCIe initiator will use to compute the proper P2P mapping mode. ATS always needs an IOVA but that still doesn't mean the P2P will work. > It seems to me that a pci-device settable flag "ATS always enabled" > should be enough to fix both issues? It should be be per-mapping to support the NIC workflow that isn't a global operation. Jason