From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 082D43D9DB0 for ; Sun, 20 Sep 2026 06:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789886107; cv=none; b=kW7/d9TY1bV8odyVM5kShCtMCpgn9UtCi07e+WgOm7hncoJH/87gPoAxlUXzRU1Sk+qqGP6ZAqf2xxJBUmG7OR+/Bj8NraMWI28HcWyRIvIRwJQWULiaLCMemRAyHbAgpX1m/wsaeZCIgtB9salg+HqftcvaMjenTuPOtBzoJ1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789886107; c=relaxed/simple; bh=BkjCl9PTzmvibgyTAzSEgHagAdnS6n+z9kSRa9z/IJM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mZ0hT3WuRI3F1Q5+Jh0ye9Lzp+Vnlk6t33/04jxgc5l//qnwwPGQbNb98NSQ7s1KkSLADFvpEP9ZkjxMqZsBi2gWyxfQMr59yv61/2CuFytzeTUExOWp9JUeNgjVcDMfo1hClTCuae+HpzpoxqPkAeP3fqjDe2aJ6119+wldx2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y4HWaiaH; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y4HWaiaH" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc1cebcb8d7so627632a12.0 for ; Sat, 19 Sep 2026 23:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789886104; x=1790490904; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=1mSNs6gpwDbZo1OHe4Pclodm2onA21KdKi2Jq9VQVaA=; b=Y4HWaiaHdhc8jyGzDCHbftM0vp1Eq2jjWDXJWgw6Gj2c0E2BA9S88ygsYF14DrZIy4 ACZ8jlQjKDp2VFR0dR7Jy9jAIYwS7qEZk4YZbiWHi5Za+EJt110hZWt7R7Ucc0Pg/CV5 VISeGOJmJ4qzVDjLVDPhZNQdhF5YkVH2CPoO+xTg6URDlOhlaaHc/aAO2SKHFQ9JWAV/ 163TEahcNmQeF76vlgxZ/XvJb1MzJueJqMjQ7FjIfqBFJs0pwmrmPggGImWLrj3UOEEY l3SdQoIMthJVVwY8iLho0EZ2JJ/OwgF8pNUY5u5zfjrNGIuP95GxoFq/Esok1qON6zPa b9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789886104; x=1790490904; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1mSNs6gpwDbZo1OHe4Pclodm2onA21KdKi2Jq9VQVaA=; b=Dq/0xBD0B7V5R1U4na0hH08rclcMzL1lqDF2IJT4aR+qCrt3+2pQHBFrCriHkbO9EB iQUnRgey3xdI4Vafs5ueuKzNqywJFvy7Q5kgXd+uSs+q6M44nGe/berSIpRKnxIA6ZJo psdaILpiv1BKf03r/o/ZwjoRppKrrI9lJ0qubPVzqGVFXEtkHMXMR0EWm0eUU+ZpVvuc qZkW6gFr4sTRiX0H/8U+E2BiNNQ4TXFoUwPMfjcI6cQBibDMv+5CwiJVyHDLGzZfGABv qy0i6fPAfBN5RHMrGZzyrmGwYFXChAhPwN1SHWpGzBxdo9t5hI5NL4GKDoDZyZdprKWk 2zww== X-Forwarded-Encrypted: i=1; AKwUvBwx3PatxZsoTrVaGjpWtm7wdHVfkAqz8pfBMLcMUNHqOuQ0KYz62L4XwxHx0TNAHr4X+bkYFJvKDJL8@vger.kernel.org X-Gm-Message-State: AFuF++l7Ir66ZOWnMqB/vE78FUnB2BffxoFNQHUSZi14EVHgDvqRsI1K seuBgbuMmmn9gyXjrqr5VjjMT1xaHT3n00diOSZFQ0UlVWf24YUI+PB5 X-Gm-Gg: AYBFou0ttyF6ZIZOnpwSCQd2c6njp74ZA7fNsZvu+lUVhbkRGTSYjWVAr2B0KRbMTiC 6hEUea+OQoA397ilKF3ZQQTRnayXwImwKvPmJbLm7rwgfeyw09VgINw51KDlLgScTa/Ei7uUX2J YyKhH/ktSiI6K+muVql40FCSdz0bZvBdQ+w1HtNG7zCpcu2Jqu6TH2RF/WOOgNjT8aYg2Vtwqfr txPcSzNNSGtz+Ithqkd65foDTI9y/oyVatOViQFus/5TZC1vaK5V46K5um5/YU9bYYFusUpIgz5 IAVaCW7gPmkwcxWpHZ+/DSLwxDlN3wlJd0y+Ub+fZYJcr9NQwi1F4A980bSM3T64/frN1y3mv/o ZF2uKZLxOtneWdEWsrR/R/595U41MUyDGDVsCmpyArp52QAgg42OfDYTBPAR64zd2Rj0sT8Y/Zz tKbfk0jzRmNTMZr2dzZGj/xt6FlXSXiL8h2rtbih56c+Iib1eqtU1IA7Z+PmIgOxQkjqMPB6Gid eZhKItXhAJqHZa90SMz/JeAdSw6gmlxmGU= X-Received: by 2002:a05:6a00:3a0d:b0:878:3704:e0ee with SMTP id d2e1a72fcca58-8783704f6efmr2520416b3a.20.1789886104157; Sat, 19 Sep 2026 23:35:04 -0700 (PDT) Received: from localhost.localdomain ([43.224.245.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-877a8dfe20dsm1711604b3a.19.2026.09.19.23.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2026 23:35:03 -0700 (PDT) From: Dongliang Qin To: netdev@vger.kernel.org Cc: achender@kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dongliang Qin Subject: [PATCH net] rds: ib: Clear the sg list when mapping an MR fails Date: Sun, 20 Sep 2026 14:34:49 +0800 Message-ID: <20260920063449.1594203-1-cccccccccccc777777@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rds_ib_map_frmr() stores the caller's scatterlist in the MR before DMA mapping and registration can fail. On failure, __rds_rdma_map() unpins the pages and frees the scatterlist, but rds_ib_free_frmr() can still return the MR to the pool with the stale pointer set. This leaves the pool with a dangling scatterlist and can lead to local privilege escalation. KASAN detects the resulting use-after-free when the MR is later torn down: BUG: KASAN: slab-use-after-free in __rds_ib_teardown_mr Read of size 8 Call Trace: __rds_ib_teardown_mr rds_ib_unreg_frmr rds_ib_flush_mr_pool rds_ib_flush_mrs rds_free_mr rds_setsockopt Clear the scatterlist fields before returning an error so the caller retains sole ownership of the scatterlist and its pinned pages. Route a zero-length DMA mapping through the same cleanup path, and skip unmap when no mapping was created. Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode") Cc: stable@vger.kernel.org Signed-off-by: Dongliang Qin --- net/rds/ib_frmr.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/net/rds/ib_frmr.c b/net/rds/ib_frmr.c index bd8611911..fea387952 100644 --- a/net/rds/ib_frmr.c +++ b/net/rds/ib_frmr.c @@ -213,7 +213,8 @@ static int rds_ib_map_frmr(struct rds_ib_device *rds_ibdev, DMA_BIDIRECTIONAL); if (unlikely(!ibmr->sg_dma_len)) { pr_warn("RDS/IB: %s failed!\n", __func__); - return -EBUSY; + ret = -EBUSY; + goto out_unmap; } frmr->sg_byte_len = 0; @@ -261,9 +262,13 @@ static int rds_ib_map_frmr(struct rds_ib_device *rds_ibdev, return ret; out_unmap: - ib_dma_unmap_sg(rds_ibdev->dev, ibmr->sg, ibmr->sg_len, - DMA_BIDIRECTIONAL); - ibmr->sg_dma_len = 0; + if (ibmr->sg_dma_len) { + ib_dma_unmap_sg(rds_ibdev->dev, ibmr->sg, ibmr->sg_len, + DMA_BIDIRECTIONAL); + ibmr->sg_dma_len = 0; + } + ibmr->sg = NULL; + ibmr->sg_len = 0; return ret; } -- 2.43.0