Re: [PATCH] net/rds: fix incoming message refcount leak and header bounds check in rds_recv.c

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] net/rds: commit message claims refcount fix but patch modifies latency trace
--

commit 80f53e33ea420eaf26746196c2c667ca4d80ade2
Author: Hui Peng <benquike@gmail.com>

net/rds: fix incoming message refcount leak and header bounds check in rds_recv.c

This commit modifies rds_cmsg_recv() to add a zero-check for latency trace
calculations.

> net/rds: fix incoming message refcount leak and header bounds check in rds_recv.c
>
> In net/rds/recv.c, ensure incoming RDS message references (rds_inc_put)
> and socket receive queue bounds are properly balanced when handling
> error or truncated incoming frames.

[Severity: Medium]
Does the commit message accurately describe the included changes?

The message explicitly claims to fix a refcount leak involving rds_inc_put
and a receive queue bounds imbalance. However, the actual code changes only
add a zero-check to diagnostic latency trace calculations:

net/rds/recv.c:rds_cmsg_recv() {
    ...
    if (inc->i_rx_lat_trace[j + 1] &&
        inc->i_rx_lat_trace[j])
        t.rx_trace[i] = inc->i_rx_lat_trace[j + 1] -
                        inc->i_rx_lat_trace[j];
    ...
}

Are the refcount and receive queue bounds fixes missing from this patch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919223429.3882046-1-benquike@gmail.com?part=1