From: sashiko-bot@kernel.org
To: "Selvin Xavier" <selvin.xavier@broadcom.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-rc v3 6/8] RDMA/bnxt_re: Serialize dcb_wq access against async notifier
Date: Tue, 22 Sep 2026 01:05:43 +0000 [thread overview]
Message-ID: <20260922010543.88D8F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922061230.7909-7-selvin.xavier@broadcom.com>
> bnxt_re_async_notifier() runs in NAPI/softirq context via bnxt_en's
> RCU-protected ULP ops dispatch, never under rtnl_lock, so it isn't
> serialized against bnxt_re_uninit_dcb_wq() destroying rdev->dcb_wq.
> A concurrent notifier call can queue_work() on a workqueue that is
> being, or has just been, destroyed.
>
> Add a spinlock scoped to dcb_wq: the notifier takes it before
> checking dcb_wq and queuing work, and bnxt_re_uninit_dcb_wq() takes
> it to atomically clear dcb_wq before destroying it. Initialize the
> lock at rdev allocation so it is valid on every teardown path,
> including bnxt_re_dev_init()'s early failure labels.
>
> Fixes: 51dc5312dcd9 ("RDMA/bnxt_re: Add support to handle DCB_CONFIG_CHANGE event")
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922061230.7909-1-selvin.xavier@broadcom.com?part=6
next prev parent reply other threads:[~2026-09-22 1:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 6:12 [PATCH for-rc v3 0/8] RDMA/bnxt_re: Fix input validation and Selvin Xavier
2026-09-22 6:12 ` [PATCH for-rc v3 1/8] RDMA/bnxt_re: Fix integer overflow in send payload size computation Selvin Xavier
2026-09-22 1:09 ` sashiko-bot
2026-09-22 6:12 ` [PATCH for-rc v3 2/8] RDMA/bnxt_re: Detect wrong sge_len passed for inline Selvin Xavier
2026-09-22 1:08 ` sashiko-bot
2026-09-22 6:12 ` [PATCH for-rc v3 3/8] RDMA/bnxt_re: Validate SRQ max_sge at create time Selvin Xavier
2026-09-22 1:07 ` sashiko-bot
2026-09-22 6:12 ` [PATCH for-rc v3 4/8] RDMA/bnxt_re: Initialize wqe.flags in bnxt_re_post_srq_recv() Selvin Xavier
2026-09-22 1:02 ` sashiko-bot
2026-09-22 6:12 ` [PATCH for-rc v3 5/8] RDMA/bnxt_re: Validate num_sge " Selvin Xavier
2026-09-22 1:07 ` sashiko-bot
2026-09-22 4:39 ` Selvin Xavier
2026-09-29 8:33 ` Leon Romanovsky
2026-09-22 6:12 ` [PATCH for-rc v3 6/8] RDMA/bnxt_re: Serialize dcb_wq access against async notifier Selvin Xavier
2026-09-22 1:05 ` sashiko-bot [this message]
2026-09-22 6:12 ` [PATCH for-rc v3 7/8] RDMA/bnxt_re: Fix the PD and DPI table size Selvin Xavier
2026-09-22 1:01 ` sashiko-bot
2026-09-22 6:12 ` [PATCH for-rc v3 8/8] RDMA/bnxt_re: Use bnxt_ext_stats_supported for counter count selection Selvin Xavier
2026-09-22 1:06 ` sashiko-bot
2026-09-29 8:34 ` (subset) [PATCH for-rc v3 0/8] RDMA/bnxt_re: Fix input validation and Leon Romanovsky
2026-09-29 8:36 ` Leon Romanovsky
2026-10-01 5:21 ` Selvin Xavier
2026-09-29 8:42 ` (subset) " Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922010543.88D8F1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox