From: sashiko-bot@kernel.org
To: "Chuck Lever" <cel@kernel.org>
Cc: linux-rdma@vger.kernel.org, "Jeff Layton" <jlayton@kernel.org>,
"Chuck Lever" <cel@kernel.org>,
"Anna Schumaker" <anna@kernel.org>
Subject: Re: [PATCH v1 2/5] SUNRPC: fire svc_defer_queue tracepoint before publishing the request
Date: Tue, 22 Sep 2026 01:57:17 +0000 [thread overview]
Message-ID: <20260922015718.2D1651F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922015128.240977-2-cel@kernel.org>
> svc_revisit() adds the deferred request to xpt_deferred, drops
> xpt_lock, and then fires trace_svc_defer_queue(), which reads the
> request's XID and source address. Once the request is on the list,
> an nfsd thread already servicing that transport can dequeue it in
> svc_deferred_dequeue(), process it, and free it in
> svc_xprt_release() before the tracepoint reads it. The window is
> narrow, but nothing keeps the request alive across it.
>
> Fire the tracepoint before the list_add(), while svc_revisit()
> still owns the request.
>
> Fixes: 8954c5c212d3 ("SUNRPC: Clean up request deferral tracepoints")
> Signed-off-by: Chuck Lever <cel@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922015128.240977-1-cel@kernel.org?part=2
next prev parent reply other threads:[~2026-09-22 1:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 1:51 [PATCH v1 1/5] SUNRPC: fire svc_xprt_free tracepoint before dropping the netns Chuck Lever
2026-09-22 1:51 ` [PATCH v1 2/5] SUNRPC: fire svc_defer_queue tracepoint before publishing the request Chuck Lever
2026-09-22 1:57 ` sashiko-bot [this message]
2026-09-22 1:51 ` [PATCH v1 3/5] svcrdma: fix a page leak in backchannel sends Chuck Lever
2026-09-22 1:58 ` sashiko-bot
2026-09-22 1:51 ` [PATCH v1 4/5] svcrdma: release a send context stranded by a partial post Chuck Lever
2026-09-22 1:59 ` sashiko-bot
2026-09-22 1:51 ` [PATCH v1 5/5] svcrdma: release a receive context stranded by a partial Read post Chuck Lever
2026-09-22 1:57 ` sashiko-bot
2026-09-22 1:57 ` [PATCH v1 1/5] SUNRPC: fire svc_xprt_free tracepoint before dropping the netns sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922015718.2D1651F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=anna@kernel.org \
--cc=cel@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox