From: sashiko-bot@kernel.org
To: "Danielle Costantino" <dcostantino@meta.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v2] net/mlx5: Don't return firmware-owned command mailboxes to the DMA pool
Date: Wed, 23 Sep 2026 19:12:35 +0000 [thread overview]
Message-ID: <20260923191235.CC3AA1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923190542.848049-1-dcostantino@meta.com>
> On a command timeout mlx5_cmd_comp_handler(forced) keeps the entry and its
> queue slot, because firmware may still complete the command and write to
> ent->lay. cmd_exec() and the callback path free the mailboxes anyway,
> while ent->lay->{in_ptr,out_ptr} still point at them.
>
> dma_pool keeps its free list node in the first 16 bytes of the block,
> which for mlx5 is the start of the command payload, so a late firmware
> write corrupts the allocator:
>
> Unable to handle kernel paging request at virtual address
> 0007c830040001a0
> pc : dma_pool_alloc+0x48/0x430 lr : mlx5_alloc_cmd_msg+0x154/0x318
> Call trace:
> dma_pool_alloc+0x48/0x430 (P)
> mlx5_alloc_cmd_msg+0x154/0x318
> [ ... ]
> allocator.
>
> Fixes: 73dd3a4839c1 ("net/mlx5: Avoid using pending command interface slots")
> Cc: stable@vger.kernel.org
> Signed-off-by: Danielle Costantino <dcostantino@meta.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923190542.848049-1-dcostantino@meta.com?part=1
next prev parent reply other threads:[~2026-09-23 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 19:05 [PATCH net v2] net/mlx5: Don't return firmware-owned command mailboxes to the DMA pool Danielle Costantino
2026-09-23 19:12 ` sashiko-bot [this message]
2026-09-27 19:22 ` netdev-bot+sashiko
2026-09-28 13:05 ` Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923191235.CC3AA1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dcostantino@meta.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox