Re: [PATCH net-next 07/13] net/mlx5e: TC, anchor peer-flow reverse index on the duplicated flow

[sashiko-bot@kernel.org]

> From: Shay Drory <shayd@nvidia.com>
> 
> A TC eswitch flow offloaded to a shared FDB is duplicated onto every
> peer eswitch. Besides the forward list of duplicates on the origin flow
> (mlx5e_tc_flow.peer_flows), the eswitch keeps a reverse index,
> esw->offloads.peer_flows[], an array of per-peer list heads keyed by the
> peer's LAG sequence number, used to tear down a peer's duplicates when
> it is removed.
> 
> That reverse index was anchored on the origin: since one origin can have
> a duplicate on every peer, the origin carried per-peer storage sized to
> the max port count - a peer[MLX5_MAX_PORTS] array of list nodes plus a
> peer_used bitmap - and each duplicate stored its peer_index.
> 
> Anchor it on the duplicate instead, which belongs to a single peer. Give
> each flow one list node, mlx5e_tc_flow.peer, and place the duplicate -
> not the origin - on its peer's list through it; add a peer_orig back-ref
> so del can reach the origin from the duplicate. One node then replaces
> the origin's per-peer array, and del unlinks the duplicate directly, so
> peer[], peer_used and peer_index are dropped.
> 
> The per-peer list heads remain the fixed esw->offloads.peer_flows[]
> array keyed by the LAG sequence number - that array is replaced in the
> next patch.  No functional change.
> 
> Signed-off-by: Shay Drory <shayd@nvidia.com>
> Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
> Reviewed-by: Akiva Goldberger <agoldberger@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923103830.1183-1-tariqt@nvidia.com?part=7