From: sashiko-bot@kernel.org
To: "Abhijit Gangurde" <abhijit.gangurde@amd.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH 2/2] RDMA/ionic: Fix double removal of CMB mmap entries in create QP error path
Date: Fri, 25 Sep 2026 09:46:56 +0000 [thread overview]
Message-ID: <20260925094656.F288A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925093638.3032149-2-abhijit.gangurde@amd.com>
> The error unwind in ionic_create_qp() removes the SQ and RQ CMB mmap
> entries explicitly, and then falls through to ionic_qp_rq_destroy() and
> ionic_qp_sq_destroy(), whose ionic_qp_{rq,sq}_destroy_cmb() helpers
> remove the very same entries a second time.
>
> Drop the explicit removals and leave ionic_qp_{rq,sq}_destroy_cmb() as
> the single owner on the ionic_destroy_qp() path.
>
> Fixes: e8521822c733 ("RDMA/ionic: Register device ops for control path")
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260925093638.3032149-1-abhijit.gangurde@amd.com?part=2
next prev parent reply other threads:[~2026-09-25 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 9:36 [PATCH 1/2] RDMA/ionic: Fix XArray initialization to use XArray flags Abhijit Gangurde
2026-09-25 9:36 ` [PATCH 2/2] RDMA/ionic: Fix double removal of CMB mmap entries in create QP error path Abhijit Gangurde
2026-09-25 9:46 ` sashiko-bot [this message]
2026-09-25 9:41 ` [PATCH 1/2] RDMA/ionic: Fix XArray initialization to use XArray flags sashiko-bot
2026-09-29 18:45 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925094656.F288A1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abhijit.gangurde@amd.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox