From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03FA23BBFBA; Sun, 27 Sep 2026 06:14:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790489697; cv=none; b=lJjs6oHOj29tAOSMo60a6YURS3BCKAE0XekFjNt71wCa8F2szXMOwSZIrlvtadA9SUggUflBllX8fa4b+uaEN0ZulwHeeK2yd+uaFF1NUAVYkuQXCVmfPSzVlG6KsL1LnO+qeHkDN5pouksaegF6TB1CbDgBgPhB59ZmmwS58Eg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790489697; c=relaxed/simple; bh=XibMn/Ey9hPyGBzVddsLIUd9I9RxhAjbJqpA1zmBf1M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TtmruUMbtix+yLIqq6J4xmAwBN0saP+3cP1GzVUwh+x1mjNU9roUvf/EcNfNtoAKQqPBjAxjPtn46PzEmO+tyyPchQMD6cm5mn/Wc8Zs54m1RWSJjWpeLit6nhaiHhvuG0STBA9qOrU66fViMmpM/51pvivyrR579uc1KlQT4UI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gu+jPICP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gu+jPICP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A0091F000FF; Sun, 27 Sep 2026 06:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790489695; bh=1epBk2rScAcFUDRFZL3sFlSrnuggVolncxrM4Xm8CyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gu+jPICPzCxh3NP5Am3HGRau4gQ0Daw53WFSQgM7612sdzY/Vfz4LUIv7NKqNEXVO 9PFzp8eUwWIyw2orU5UKoeAl02kaD40fC6Co0YfrNBFh7DAPXJsI6nJ+w4XvEzuet8 RmE00G+WBcAZDEcLHuYtUd1f1disEhFgWdVXB4CAnPJTM08210sPNLWOLh3bzs56ZJ RaQ0SAeCDA6bRoqOLkGDknqcZLWPOKp+cOCk5rMArWYWKE2X1MOzZGybgvtWoqdye3 K/mB1vc1gzC1MXhDxWIIU7fs6f6YlXhpwoR/PAvVRa1wmYR8kH7DDx4Qd8WGONgTBj 2haZ6RbisBi0w== From: Allison Henderson To: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, kuba@kernel.org, horms@kernel.org Cc: achender@kernel.org Subject: [PATCH net-next v7 12/12] net/rds: drop rds_conn_count in favor of t_conn_count Date: Sat, 26 Sep 2026 23:14:48 -0700 Message-Id: <20260927061448.167862-13-achender@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260927061448.167862-1-achender@kernel.org> References: <20260927061448.167862-1-achender@kernel.org> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The previous patch gave each transport its own connection count in t_conn_count, incremented and decremented at exactly the points where the global rds_conn_count is. That leaves rds_conn_count with a single remaining consumer: the seed of the per-path workqueue names in __rds_conn_create(). Switch the name seed to t_conn_count, as UEK does, and remove rds_conn_count. The numbering becomes per-transport instead of global, so connections of different transports can now receive the same seed; workqueue names carry no uniqueness requirement, and the seed was already reused as the count rose and fell. Removing the counter also removes the rds_conn_lock round-trip that rds_conn_destroy_fini() took solely to decrement it. (The free path still sleeps in destroy_workqueue(), so the last reference has to be dropped from process context as before; only that one lock goes.) Based on the Oracle UEK commit "net/rds: Each RDS transport should keep its own connection count". Assisted-by: Claude-Code:claude-fable-5 Signed-off-by: Allison Henderson --- net/rds/connection.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/net/rds/connection.c b/net/rds/connection.c index 960fc5732c6e..c13b98df3476 100644 --- a/net/rds/connection.c +++ b/net/rds/connection.c @@ -47,7 +47,6 @@ /* converting this to RCU is a chore for another day.. */ static DEFINE_SPINLOCK(rds_conn_lock); -static unsigned long rds_conn_count; /* woken whenever a transport's t_conn_count drops to zero */ static DECLARE_WAIT_QUEUE_HEAD(rds_conn_freed_waitq); static struct hlist_head rds_conn_hash[RDS_CONNECTION_HASH_ENTRIES]; @@ -338,12 +337,13 @@ static struct rds_connection *__rds_conn_create(struct net *net, init_waitqueue_head(&conn->c_hs_waitq); for (i = 0; i < npaths; i++) { + int seq = atomic_read(&trans->t_conn_count); + __rds_conn_path_init(conn, &conn->c_path[i], is_outgoing); conn->c_path[i].cp_index = i; conn->c_path[i].cp_wq = - alloc_ordered_workqueue("krds_cp_wq#%lu/%d", 0, - rds_conn_count, i); + alloc_ordered_workqueue("krds_cp_wq#%d/%d", 0, seq, i); if (!conn->c_path[i].cp_wq) conn->c_path[i].cp_wq = rds_wq; } @@ -414,7 +414,6 @@ static struct rds_connection *__rds_conn_create(struct net *net, rds_conn_get(conn); /* caller */ rcu_assign_pointer(parent->c_passive, conn); rds_cong_add_conn(conn); - rds_conn_count++; atomic_inc(&conn->c_trans->t_conn_count); } } else { @@ -437,7 +436,6 @@ static struct rds_connection *__rds_conn_create(struct net *net, rds_conn_get(conn); hlist_add_head_rcu(&conn->c_hash_node, head); rds_cong_add_conn(conn); - rds_conn_count++; atomic_inc(&conn->c_trans->t_conn_count); } } @@ -681,7 +679,6 @@ static void rds_conn_destroy_fini(struct kref *kref) c_refcount); int npaths = (conn->c_trans->t_mp_capable ? RDS_MPATH_WORKERS : 1); struct rds_transport *trans = conn->c_trans; - unsigned long flags; int i; for (i = 0; i < npaths; i++) @@ -690,10 +687,6 @@ static void rds_conn_destroy_fini(struct kref *kref) kfree(conn->c_path); kmem_cache_free(rds_conn_slab, conn); - spin_lock_irqsave(&rds_conn_lock, flags); - rds_conn_count--; - spin_unlock_irqrestore(&rds_conn_lock, flags); - /* only after everything the transport module owns has been * freed above may its unload proceed */ -- 2.25.1