Re: [PATCH net] net/smc: Serialize link activation with teardown

[sashiko-bot@kernel.org]

> smc_llc_link_active() marks a link active before scheduling its testlink
> work. The first-link confirmation paths call it without llc_conf_mutex,
> allowing link-down processing to clear the link between these operations:
> 
>   Connection setup                    Link-down worker
>   smc_llc_link_active()
>     link->state = SMC_LNK_ACTIVE
>                                       smcr_link_clear()
>                                         link->clearing = 1
>                                         smc_llc_link_clear()
>                                           cancel_delayed_work_sync()
>     schedule_delayed_work()
> 
> The connection reference keeps the link alive during activation, but the
> newly queued work outlives that reference. Later cleanup skips clearing
> [ ... ]
> without changing the handshake sequence or error handling.
> 
> Fixes: 877ae5be421d ("net/smc: periodic testlink support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Chengfeng Ye <nicoyip.dev@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927074547.3694742-1-nicoyip.dev@gmail.com?part=1