From: sashiko-bot@kernel.org
To: "Hongyan Xu" <getshell@seu.edu.cn>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/hfi1: shut down the trap timer before unregistering
Date: Mon, 28 Sep 2026 13:52:53 +0000 [thread overview]
Message-ID: <20260928135254.1264F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928134151.1213-1-getshell@seu.edu.cn>
> MAD processing arms a trap timer embedded in each hfi1_ibport. Device
> unregistration does not stop the timer, so its callback can run after
> the port and its containing hfi1_devdata have been released.
>
> Shut down every port timer before unregistering the IB device. The
> shutdown form also prevents a concurrent path from rearming the timer.
>
> Fixes: bf90aadd630c ("IB/hfi1: Send MAD traps until repressed")
> Signed-off-by: Hongyan Xu <getshell@seu.edu.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928134151.1213-1-getshell@seu.edu.cn?part=1
next prev parent reply other threads:[~2026-09-28 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 13:41 [PATCH] RDMA/hfi1: shut down the trap timer before unregistering Hongyan Xu
2026-09-28 13:52 ` sashiko-bot [this message]
2026-09-30 12:00 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928135254.1264F1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=getshell@seu.edu.cn \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox