From: sashiko-bot@kernel.org
To: "Artem Dinaburg" <artem@trailofbits.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH 6.6.y] net/mlx5e: Fix netif state handling
Date: Wed, 30 Sep 2026 01:34:48 +0000 [thread overview]
Message-ID: <20260930013448.7D78A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930012143.95721-1-artem@trailofbits.com>
> From: Shay Drory <shayd@nvidia.com>
>
> [ Upstream commit 3d5918477f94e4c2f064567875c475468e264644 ]
>
> mlx5e_suspend cleans resources only if netif_device_present() returns
> true. However, mlx5e_resume changes the state of netif, via
> mlx5e_nic_enable, only if reg_state == NETREG_REGISTERED.
> In the below case, the above leads to NULL-ptr Oops[1] and memory
> leaks:
>
> mlx5e_probe
> _mlx5e_resume
> mlx5e_attach_netdev
> mlx5e_nic_enable <-- netdev not reg, not calling netif_device_attach()
> register_netdev <-- failed for some reason.
> [ ... ]
> Reviewed-by: Simon Horman <horms@kernel.org>
> Link: https://lore.kernel.org/r/20240509112951.590184-2-tariqt@nvidia.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Assisted-by: LLM
> Signed-off-by: Artem Dinaburg <artem@trailofbits.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930012143.95721-1-artem@trailofbits.com?part=1
next prev parent reply other threads:[~2026-09-30 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 1:21 [PATCH 6.6.y] net/mlx5e: Fix netif state handling Artem Dinaburg
2026-09-30 1:23 ` netdev-bot+sinfo
2026-09-30 1:34 ` sashiko-bot [this message]
2026-10-01 13:52 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930013448.7D78A1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=artem@trailofbits.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox