From: sashiko-bot@kernel.org
To: "Runyu Xiao" <runyu.xiao@seu.edu.cn>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/hfi1: Shutdown self-rearming timers before freeing
Date: Wed, 30 Sep 2026 07:24:34 +0000 [thread overview]
Message-ID: <20260930072434.857601F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930070455.2934286-1-runyu.xiao@seu.edu.cn>
> The HFI1 receive error and synthetic counter timers rearm themselves from
> their callbacks. Their cleanup paths use timer_delete_sync(), which only
> waits for a running callback and does not prevent a concurrent or
> subsequent rearm.
>
> Use timer_shutdown_sync() when releasing these timers. This prevents a
> callback from enqueueing either timer after cleanup begins, before the
> containing hfi1_devdata is freed.
>
> Preserve the existing work cancellation and workqueue destruction ordering
> for synthetic counters.
>
> Fixes: 7724105686e7 ("IB/hfi1: add driver files")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930070455.2934286-1-runyu.xiao@seu.edu.cn?part=1
next prev parent reply other threads:[~2026-09-30 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 7:04 [PATCH] IB/hfi1: Shutdown self-rearming timers before freeing Runyu Xiao
2026-09-30 7:24 ` sashiko-bot [this message]
2026-09-30 13:25 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930072434.857601F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox