From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH mlx5-next V2 10/10] mlx5: Move data direct implementation to mlx5_core
Date: Wed, 30 Sep 2026 11:56:04 +0000 [thread overview]
Message-ID: <20260930115605.2FFD21F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930114227.139274-11-tariqt@nvidia.com>
> From: Dragos Tatulea <dtatulea@nvidia.com>
>
> As data direct will also be used by netdev devices, move the data direct
> code to mlx5_core. Now mlx5_core is responsible for data direct
> initialization and resource creation.
>
> Now data_direct is initialized in mlx5_load() before attaching consumers
> and clean it up in mlx5_unload() after detaching them. The data direct
> PCI driver is moved and registered in mlx5_core.
>
> IB specific work stays in mlx5_ib: notifier registration, mutex
> initialization and MR list initialization.
>
> Failure to query the VUID is now fatal because this is done only on
> devices that support data direct. Other than this, this patch has no
> additional functional changes.
>
> Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930114227.139274-1-tariqt@nvidia.com?part=10
next prev parent reply other threads:[~2026-09-30 11:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 11:42 [PATCH mlx5-next V2 00/10] mlx5: Move data direct infrastructure to mlx5_core Tariq Toukan
2026-09-30 11:42 ` [PATCH mlx5-next V2 01/10] RDMA/mlx5: Notify data direct users via a notifier chain on unbind Tariq Toukan
2026-09-30 11:56 ` sashiko-bot
2026-09-30 11:42 ` [PATCH mlx5-next V2 02/10] RDMA/mlx5: Add mlx5_data_direct_supported() helper Tariq Toukan
2026-09-30 11:56 ` sashiko-bot
2026-09-30 11:42 ` [PATCH mlx5-next V2 03/10] RDMA/mlx5: Make the data direct VUID query self-contained Tariq Toukan
2026-09-30 11:56 ` sashiko-bot
2026-09-30 11:42 ` [PATCH mlx5-next V2 04/10] RDMA/mlx5: Give the data direct PCI driver a proper name Tariq Toukan
2026-09-30 11:55 ` sashiko-bot
2026-09-30 11:42 ` [PATCH mlx5-next V2 05/10] RDMA/mlx5: Move and rename data direct resource functions Tariq Toukan
2026-09-30 11:55 ` sashiko-bot
2026-09-30 11:42 ` [PATCH mlx5-next V2 06/10] RDMA/mlx5: Add new registration stage for data direct users Tariq Toukan
2026-09-30 11:56 ` sashiko-bot
2026-09-30 11:42 ` [PATCH mlx5-next V2 07/10] RDMA/mlx5: Extract IB specific lock out of data direct Tariq Toukan
2026-09-30 11:56 ` sashiko-bot
2026-09-30 11:42 ` [PATCH mlx5-next V2 08/10] RDMA/mlx5: Consolidate data direct state into one object Tariq Toukan
2026-09-30 11:56 ` sashiko-bot
2026-09-30 11:42 ` [PATCH mlx5-next V2 09/10] RDMA/mlx5: Pull data_direct resource creation in init phase Tariq Toukan
2026-09-30 11:56 ` sashiko-bot
2026-09-30 11:42 ` [PATCH mlx5-next V2 10/10] mlx5: Move data direct implementation to mlx5_core Tariq Toukan
2026-09-30 11:56 ` sashiko-bot [this message]
2026-10-01 15:41 ` [PATCH mlx5-next V2 00/10] mlx5: Move data direct infrastructure " Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930115605.2FFD21F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox