Re: [PATCH net V2 3/4] net/mlx5e: Serialize TC and IPsec offload exclusion counters

[sashiko-bot@kernel.org]

> From: Cosmin Ratiu <cratiu@nvidia.com>
> 
> The counters enforcing TC and IPsec packet offload mutual exclusion are
> not consistently serialized. The IPsec add path conditionally takes the
> eswitch write lock, but neither release path takes it. The TC add path
> only holds the eswitch read lock, and devices without an eswitch cannot
> rely on that lock at all.
> 
> Concurrent read-modify-write operations on the same counter can lose an
> update. A stale nonzero count can keep rejecting offload requests after
> the last user has gone, while an undercount can allow conflicting
> offloads to coexist.
> 
> Move the counters into mdev->offload_block and protect all checks,
> increments and decrements with a dedicated mutex. Keep the
> opposing-counter check and reservation in the same critical section,
> independent of eswitch availability. Initialize the lock for the core
> device lifetime and add warnings for unbalanced releases.
> 
> Fixes: c8e350e62fc5 ("net/mlx5e: Make TC and IPsec offloads mutually exclusive on a netdev")
> Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930121119.141953-1-tariqt@nvidia.com?part=3