Re: [PATCH net v4 2/2] net/rds: don't let the rdma_cm destroy an id RDS still owns on route failure

[sashiko-bot@kernel.org]

> rds_rdma_cm_event_handler_cmn() hands the return value of
> rdma_resolve_route() straight back to the rdma_cm on
> RDMA_CM_EVENT_ADDR_RESOLVED.  A synchronous failure there - -ENOMEM
> from the route work allocation, an SA query that cannot be set up, a
> RoCE route with no usable device - makes addr_handler() destroy the
> id the event was delivered on.  That id is ic->i_cm_id, and nothing
> clears the pointer: the connection sits in RDS_CONN_CONNECTING with a
> freed id until its shutdown calls rdma_disconnect() and
> rdma_destroy_id() on it.
> 
> The ROUTE_RESOLVED case already avoids this: rds_ib_cm_initiate_connect()
> forces a zero return while ic->i_cm_id == cm_id, as the comment there
> explains.  Do the same here - drop the connection and return 0 - so
> the id stays RDS's to destroy from the shutdown, and the reconnect
> gets a fresh one.
> 
> Fixes: 55b7ed0b582f ("RDS: Common RDMA transport code")
> Assisted-by: Claude-Code:claude-fable-5
> Signed-off-by: Allison Henderson <achender@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261003163408.250568-1-achender@kernel.org?part=2