From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f43.google.com (mail-dy2-f43.google.com [74.125.229.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD90D42379A for ; Sun, 4 Oct 2026 10:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791111091; cv=none; b=BFBaZnod7GL9z/1bcWLe8eE6zUmmvD1UNID9QkdnCu7ABWylF4XdaNdwiDBM03V+ZTs/FMM6X4RVqusTYIMBJzfNq/xP0KUTS5Z6DWPxtQ5w/8Qfia8XhdxxwXJFzYGi4o2NhOcaKVjxNvdYZ54oLCRZ8K8mjFnwJOlPki4vJOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791111091; c=relaxed/simple; bh=4MRxwd7MzrAqfyJ7mimlrfGaFAcX/tkMDz0Yg+CsHtE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i46SRusHtjdEJZDAyHMxZO+b6Ck+tjjrcaDLsmG+1NO9a+rxVKp1fDdLtcAib3pEwB3Vyj/4E04SJgq18Ff5IMtbdIWXEmSDeHH+FvuKFrEx3QfZs9sAbfIb0NkOADGA7bDdSGpwh5iRHl78Bn5osDdPhQEo6JvImS+HpauK6eI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OVA34rGy; arc=none smtp.client-ip=74.125.229.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OVA34rGy" Received: by mail-dy2-f43.google.com with SMTP id 5a478bee46e88-33e46a156f4so818122eec.0 for ; Sun, 04 Oct 2026 03:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791111087; x=1791715887; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OU10JUkOnCjExkP9pLJslSiL15VSpV7uAw3VaBnuTMo=; b=OVA34rGyoQxPo0wRv2zEemiSYWkKsDXwZStVOByBQRpu1DQU+Ux1wXdGhPRfPWJ2ht ouzg/l9fDoy4wZ4euP5p8lSaoWg9rG9fZaKYtejcMe2sLNInHQTJRfxfmQZMe1qawkEv rk+ljgwDABA0aWwMOyjO7W2/GmSrlrEnlMsehl8voU4xsbmKVz9gk/Ogj6oGfr8ii6sS l3qesCpMjIJp2mX/KknTTgJj92xvPMlxpmMvI3gaZdf5nWW0UYLAXpFpOv2tT9v3D2Li xbUQ3aLXlQsME980CGogDR3xWSx3k1tqD8k2m/VTgDE0NLGWeD4a92JNkkElYfXQZNzC HlPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791111087; x=1791715887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OU10JUkOnCjExkP9pLJslSiL15VSpV7uAw3VaBnuTMo=; b=ESs2luByXXE4ElCECK+2Qie15TPnEMxUSrqK2NzoTPCF7Z8Xv/WYOmcfz08ozXDQ9u Kj0J/aQAAgLH+jn0OZaHwpBzINUh4PZKR/LbdbXxPC0uFwgO5GWVGPLxXvVi+u8wdqgx UBFxqbdNWRY+XISO1E0uMri6ybNem5xe93h2nhgLylRHZDFF3lF0pY+a+06DqHqhTXbO 1qleKU5vJkQf44p3YOhy1JENadD78ItunhVDFb+WZDusRhKOrDP65scxPjnCQE1L7v9f hw+f1NsRG/6ZoUVEd9G7BK6qguHfT3S4pfpj1Hrk0bSFL18oHazTPEsoGnlKjqOAKp7p rMcw== X-Forwarded-Encrypted: i=1; AKwUvByZfak/o6vRuFuwFzHLtOiYc2nm7CfMKhc9L84/4kmCS7Q4NMNAVYrpPfr2lEgYgPIIIb+G3dAtSM5T@vger.kernel.org X-Gm-Message-State: AFq9FYJeOtZia2tSYvQ4B4Wm1LxB31/73YnEkzyA/WiOn6jX0+7bKwfJ sZ8Rnw/A5nEHivECk17ifE44pz9H3xJT/+Ol9CrejqcKsit4a0KYPr55 X-Gm-Gg: AYBFou3HRJtAciad2FSEda4H8sJZhzqkM4lG6/hEFvPeziT12W0vGVI0qsXSt9Mn2UX ujHI/mz19zLNaBhwQBwrB46cR03V+vgYtwRT1Y9A/12LbW0/+kbqnC12eoCX/5d/5wGQX72/nKZ dyP95zpH4n9n3AWVCQ6MemVaqAhcLa2Mx/sspbpasr3dJxP3PG+RxTCdqKCLThn6JlPQ0zScXr6 0GHrrJsVo8rEvSrhe7ZhaQq0WoWjtLf1N4fWp5BRjIAVXfRwQtsmF511kBwlWIq4Yon2fEJT26/ c26MGVT7anHTaii775ZODsQu6Uu6BWsv/SBaFot6f1y7/OlqyFAMBckcmFN37i07boe73k8k6/I hAtSZ1myHRr9II6xtZTO3t0h6sh9Yrnh4oE7pL0Hbu7uwJoJAdXcFplZTWs95XNKWuYwdii+Jkb GjpKwDOkfjofCebbXCm1EUAvOlAUUuSRy++jd0zRetKHeatDwZBrDAKlhc3MqP41ksY9Ayk7KaV VwufblRHw3AGs++6Z8IakCDvgOdEPY1ST9GAZVP2coxf4Y= X-Received: by 2002:a05:7300:e5c2:b0:341:3ca2:de2d with SMTP id 5a478bee46e88-34f15077edfmr9383419eec.6.1791111087081; Sun, 04 Oct 2026 03:51:27 -0700 (PDT) Received: from Anshuman ([123.63.59.156]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-35127161474sm3815965eec.13.2026.10.04.03.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2026 03:51:26 -0700 (PDT) From: Anshuman To: kees@kernel.org Cc: Frank.Li@kernel.org, James.Bottomley@HansenPartnership.com, airlied@gmail.com, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, anton.ivanov@cambridgegreys.com, apparmor@lists.ubuntu.com, atomlin@atomlin.com, benjamin.berg@intel.com, bhelgaas@google.com, bp@alien8.de, bvanassche@acm.org, corey@minyard.net, da.gomez@kernel.org, daniel.lezcano@kernel.org, dave.hansen@linux.intel.com, david.e.box@linux.intel.com, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, dvyukov@google.com, elver@google.com, eperezma@redhat.com, georgia.garcia@canonical.com, glider@google.com, gor@linux.ibm.com, gregkh@linuxfoundation.org, hansg@kernel.org, hare@suse.de, hca@linux.ibm.com, hpa@zytor.com, ilpo.jarvinen@linux.intel.com, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, jasowang@redhat.com, jbaron@akamai.com, jgg@ziepe.ca, jim.cromie@gmail.com, jirislaby@kernel.org, jmorris@namei.org, johannes@sipsolutions.net, john.johansen@canonical.com, joonas.lahtinen@linux.intel.com, kasan-dev@googlegroups.com, kvm@vger.kernel.org, laurent.pinchart@ideasonboard.com, lenb@kernel.org, leon@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-serial@vger.kernel.org, linux-um@lists.infradead.org, linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lukasz.luba@arm.com, macro@orcam.me.uk, martin.petersen@oracle.com, mcgrof@kernel.org, mchehab@kernel.org, mingo@redhat.com, mst@redhat.com, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, paul@paul-moore.com, pbonzini@redhat.com, pengpeng@iscas.ac.cn, peterz@infradead.org, petr.pavlu@suse.com, qemu-devel@nongnu.org, rafael@kernel.org, richard@nod.at, rodrigo.vivi@intel.com, rui.zhang@intel.com, samitolvanen@google.com, seanjc@google.com, serge@hallyn.com, simona@ffwll.ch, somlo@cmu.edu, srinivas.pandruvada@linux.intel.com, stable@vger.kernel.org, stern@rowland.harvard.edu, tglx@kernel.org, tiwei.btw@antgroup.com, tursulin@ursulin.net, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, vkoul@kernel.org, x86@kernel.org, xuanzhuo@linux.alibaba.com Subject: Re: [PATCH 01/11] params: bound array element output to the caller's page buffer Date: Sun, 4 Oct 2026 16:17:41 +0530 Message-ID: <20261004104741.51238-1-anshumantewari123@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260521133326.2465264-1-kees@kernel.org> References: <20260521133326.2465264-1-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, May 21, 2026 at 06:33:14AM -0700, Kees Cook wrote: > ret = min(ret, (int)(PAGE_SIZE - 1 - off)); > if (!ret) > break; One question about the truncation behavior here: when an element does not fully fit in the remaining buffer, this min() can cause only part of that element to be copied. For example, if the remaining space is 4 bytes and the next element produces "123456789\n", the resulting output could contain only "1234". This leaves the reader with no way to distinguish a genuinely short value from one that was truncated due to the PAGE_SIZE limit, while the array otherwise still looks like a normal comma-separated list. Is this partial-element truncation intentional for this patch, or is the expectation that it gets handled as part of the later seq_buf conversion? Would it be preferable to avoid copying an element unless it fits completely, and leave the larger-buffer case to be addressed later in the series?