Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net V2] net/mlx5: Lag, reset vport speed on MPESW teardown
Date: Tue, 06 Oct 2026 11:32:17 +0000	[thread overview]
Message-ID: <20261006113217.86EAC1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261006112415.259157-1-tariqt@nvidia.com>

> From: Or Har-Toov <ohartoov@nvidia.com>
> 
> mlx5_lag_disable_mpesw() never called mlx5_lag_reset_vports_speed(),
> unlike regular LAG teardown in mlx5_do_bond(), leaving stale cached and
> FW-configured speeds after MPESW is torn down.
> 
> Call it from mlx5_lag_disable_mpesw() as well, so the reset is paired
> with mlx5_lag_set_vports_agg_speed() on the MPESW path too.
> 
> Fixes: 50f1d188c580 ("net/mlx5: Propagate LAG effective max_tx_speed to vports")
> Signed-off-by: Or Har-Toov <ohartoov@nvidia.com>
> Reviewed-by: Shay Drori <shayd@nvidia.com>
> Reviewed-by: Mark Bloch <mbloch@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006112415.259157-1-tariqt@nvidia.com?part=1


  parent reply	other threads:[~2026-10-06 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 11:24 [PATCH net V2] net/mlx5: Lag, reset vport speed on MPESW teardown Tariq Toukan
2026-10-06 11:29 ` netdev-bot+sinfo
2026-10-07 12:28   ` Or Har-Toov
2026-10-06 11:32 ` sashiko-bot [this message]
2026-10-08 11:25 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006113217.86EAC1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox