From: sashiko-bot@kernel.org
To: "Seongjun Hong" <hsj0512@snu.ac.kr>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v2] net/mlx5: allocate DMA pool structs on the pool's NUMA node
Date: Tue, 06 Oct 2026 14:22:32 +0000 [thread overview]
Message-ID: <20261006142232.A7B2E1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261006-net-mlx5-numa-allocate-pool-page-v2-1-0dc4c2eb1376@snu.ac.kr>
> The mlx5 DMA pool structs (mlx5_dma_pool, mlx5_dma_pool_page and its
> block bitmap, and mlx5_frag_buf_node_pools) are allocated without a
> node hint, so they land on the node of whichever CPU happens to create
> or fill the pool, while the DMA pages they describe are allocated on
> the pool's node.
>
> The pool, page and bitmap are dereferenced on every block allocation
> and free. Allocate them on the pool's NUMA node as well, so that all
> of a pool's state lives on one node.
>
> These allocations happen on the control path, so the performance gain
> is expected to be small; the change is mainly for consistency.
>
> Signed-off-by: Seongjun Hong <hsj0512@snu.ac.kr>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261006-net-mlx5-numa-allocate-pool-page-v2-1-0dc4c2eb1376@snu.ac.kr?part=1
next prev parent reply other threads:[~2026-10-06 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 14:16 [PATCH net-next v2] net/mlx5: allocate DMA pool structs on the pool's NUMA node Seongjun Hong
2026-10-06 14:22 ` sashiko-bot [this message]
2026-10-06 21:57 ` Jacob Keller
2026-10-07 1:56 ` Seongjun Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006142232.A7B2E1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=hsj0512@snu.ac.kr \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox