From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: patchwork-bot+netdevbpf@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
bpf@vger.kernel.org, ayush.sawal@chelsio.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
pabeni@redhat.com, tariqt@nvidia.com, horms@kernel.org,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
ncardwell@google.com, kuniyu@google.com,
john.fastabend@gmail.com, sd@queasysnail.net,
ebiggers@kernel.org, kees@kernel.org,
aleksandr.loktionov@intel.com, petrm@nvidia.com,
u.kleine-koenig@baylibre.com, j.raczynski@samsung.com,
wang.zhan@smartx.com, willemb@google.com
Subject: Re: [PATCH net-next v3 0/6] net: unify symmetric netmem and page_pool refcounting
Date: Tue, 20 Oct 2026 15:13:52 -0700 [thread overview]
Message-ID: <20261020151352.794bf03b@kernel.org> (raw)
In-Reply-To: <CAHS8izPZ18v_1CnRkaAAA=d94wutJhoOZdOFO_1CEXSexd_=EQ@mail.gmail.com>
On Tue, 20 Oct 2026 15:10:03 -0700 Mina Almasry wrote:
> > You should have followed more modern naming patterns tho
> > get_netmem() is pretty bad IMO. PP naming is object_action()
> > so netmem_ref() or netmem_inc_ref() would be better, no?
>
> Ah, I didn't know about the modern naming. I made get_netmem mirror
> get_page. I now notice it's folio_get not get_folio. I can follow up
> with a cleanup when net-next reopens. I assume that will not be a lot
> of code churn. I was also going to try to look into deleting and
> consolidating some of the now-redundant ref-ing functions anyway.
If you do it soon I think we can try to squeeze it into this merge
window to avoid unnecessary burden for backports.
> I can also make it one of the design pricnciple in the page_pool docs
> so that the LLMs pick up good naming practices moving forward.
I don't think it's needed. I mean, if at all we should perhaps
think about naming guidelines for all of netdev, but no time for that
right now..
next prev parent reply other threads:[~2026-10-20 22:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 17:37 [PATCH net-next v3 0/6] net: unify symmetric netmem and page_pool refcounting Mina Almasry
2026-10-14 17:37 ` [PATCH net-next v3 1/6] netmem: rename __get/__put_netmem() to get/put_net_iov() Mina Almasry
2026-10-14 18:44 ` sashiko-bot
2026-10-15 20:37 ` netdev-bot+sashiko
2026-10-16 3:44 ` Mina Almasry
2026-10-14 17:37 ` [PATCH net-next v3 2/6] net: skbuff: add napi_pp_get_page() and use it in tcp_recvmsg_dmabuf() Mina Almasry
2026-10-14 18:44 ` sashiko-bot
2026-10-15 20:37 ` netdev-bot+sashiko
2026-10-16 3:47 ` Mina Almasry
2026-10-14 17:37 ` [PATCH net-next v3 3/6] net: skbuff: replace skb_page_unref() and __skb_frag_unref() with skb_netmem_unref() Mina Almasry
2026-10-14 18:44 ` sashiko-bot
2026-10-14 21:25 ` Stanislav Fomichev
2026-10-14 22:05 ` Mina Almasry
2026-10-14 22:39 ` Stanislav Fomichev
2026-10-15 20:37 ` netdev-bot+sashiko
2026-10-16 3:48 ` Mina Almasry
2026-10-14 17:37 ` [PATCH net-next v3 4/6] net: skbuff: replace __skb_frag_ref() with symmetric skb_netmem_ref() Mina Almasry
2026-10-14 18:44 ` sashiko-bot
2026-10-15 20:37 ` netdev-bot+sashiko
2026-10-19 15:17 ` Mina Almasry
2026-10-19 12:35 ` Antony Antony
2026-10-14 17:37 ` [PATCH net-next v3 5/6] net: skbuff: use skb_frag_ref() in skb_try_coalesce() Mina Almasry
2026-10-14 18:44 ` sashiko-bot
2026-10-14 17:37 ` [PATCH net-next v3 6/6] net: kunit: test netmem, page_pool, and skb frag refcounting Mina Almasry
2026-10-14 18:44 ` sashiko-bot
2026-10-15 20:37 ` netdev-bot+sashiko
2026-10-15 21:36 ` [PATCH net-next v3 0/6] net: unify symmetric netmem and page_pool refcounting Stanislav Fomichev
2026-10-20 10:10 ` patchwork-bot+netdevbpf
2026-10-20 16:23 ` Mina Almasry
2026-10-20 22:03 ` Jakub Kicinski
2026-10-20 22:10 ` Mina Almasry
2026-10-20 22:13 ` Jakub Kicinski [this message]
2026-10-20 22:27 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020151352.794bf03b@kernel.org \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=ayush.sawal@chelsio.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=edumazet@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=j.raczynski@samsung.com \
--cc=john.fastabend@gmail.com \
--cc=kees@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=petrm@nvidia.com \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
--cc=tariqt@nvidia.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wang.zhan@smartx.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox