From: Simon Horman <horms@kernel.org>
To: Peter Morrow <pdmorrow@gmail.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Yishai Hadas <yishaih@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
regressions@lists.linux.dev
Subject: Re: [PATCH net] net/mlx4: always create the eth and ib auxiliary devices
Date: Fri, 23 Oct 2026 17:56:34 +0100 [thread overview]
Message-ID: <20261023165634.GA888721@horms.kernel.org> (raw)
In-Reply-To: <CAFcZKTyrRKS+A1cb4ZrjgbEwJpEHMVNCW=Bx+emzrBdC8H-mug@mail.gmail.com>
On Fri, Oct 23, 2026 at 03:08:23PM +0100, Peter Morrow wrote:
> On Thu, 22 Oct 2026 at 11:19, Simon Horman <horms@kernel.org> wrote:
> >
> > Thanks, this looks good to me.
> > And I think the minimal approach taken here is appropriate for net.
> >
> > Reviewed-by: Simon Horman <horms@kernel.org>
> >
> > I do, however, wonder if a follow-up is warranted.
> > It seems to me that the is_supported callback could
> > be removed entirely. Leaving either:
> > 1. struct mlx4_adev_device with a single member, .suffix
> > 2. mlx4_adev_devices as an array of of strings
> >
> > To explore this idea a little further I tried coding-up approach 2.
> > Which lead to the following (compile tested only):
> [...]
>
> Thanks Simon. Agreed, a cleanup here would be nice. I'm happy to test
> and send your suggested patch to net-next once/if the reviewed change is
> merged, unless you'd like to send it yourself.
Thanks Peter,
If you could handle preparing and posting a formal patch I'd be most grateful.
next prev parent reply other threads:[~2026-10-23 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 16:42 [PATCH net] net/mlx4: always create the eth and ib auxiliary devices Peter Morrow
2026-10-20 16:48 ` sashiko-bot
2026-10-22 10:19 ` Simon Horman
2026-10-23 14:08 ` Peter Morrow
2026-10-23 16:56 ` Simon Horman [this message]
2026-10-23 11:22 ` Daniel Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023165634.GA888721@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pdmorrow@gmail.com \
--cc=petr.pavlu@suse.com \
--cc=regressions@lists.linux.dev \
--cc=tariqt@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox